-
Notifications
You must be signed in to change notification settings - Fork 0
/
DIP_Bad.cs
94 lines (91 loc) · 2.15 KB
/
DIP_Bad.cs
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
namespace SOLID_Principles.DIP.Bad
{
public class FileLogger
{
public void LogMessage(string aStackTrace)
{
//code to log stack trace into a file.
}
}
public class ExceptionLogger
{
public void LogIntoFile(Exception aException)
{
FileLogger objFileLogger = new FileLogger();
objFileLogger.LogMessage(GetUserReadableMessage(aException));
}
private string GetUserReadableMessage(Exception ex)
{
string strMessage = string.Empty;
//code to convert Exception's stack trace and message to user readable format.
//....
//....
return strMessage;
}
}
public class DataExporter
{
public void ExportDataFromFile()
{
try
{
//code to export data from files to database.
}
catch (Exception ex)
{
// *** bad smell
new ExceptionLogger().LogIntoFile(ex); // <-- client wants to store this stack trace in a database if an IO exception occurs.
}
}
}
/// <summary>
/// try to use DbLogger instead of ExceptionLogger and FileLogger
/// but it is the same FileLogger, unless class name
/// </summary>
public class DbLogger
{
public void LogMessage(string aMessage)
{
//Code to write message in database.
}
}
public class ExceptionLogger_Avoid_FileLogger_Dependecy
{
public void LogIntoFile(Exception aException)
{
FileLogger objFileLogger = new FileLogger();
objFileLogger.LogMessage(GetUserReadableMessage(aException));
}
public void LogIntoDataBase(Exception aException)
{
DbLogger objDbLogger = new DbLogger();
objDbLogger.LogMessage(GetUserReadableMessage(aException));
}
private string GetUserReadableMessage(Exception ex)
{
string strMessage = string.Empty;
//code to convert Exception's stack trace and message to user readable format.
//....
//....
return strMessage;
}
}
public class DataExporter_Implement_DbLogger
{
public void ExportDataFromFile()
{
try
{
//code to export data from files to database.
}
catch (IOException ex)
{
new ExceptionLogger_Avoid_FileLogger_Dependecy().LogIntoDataBase(ex);
}
catch (Exception ex)
{
new ExceptionLogger_Avoid_FileLogger_Dependecy().LogIntoFile(ex);
}
}
}
}