Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We seem to have some redundancy with "e2e" and "unit tests" #448

Open
GalRogozinski opened this issue Jul 3, 2024 · 0 comments
Open

We seem to have some redundancy with "e2e" and "unit tests" #448

GalRogozinski opened this issue Jul 3, 2024 · 0 comments

Comments

@GalRogozinski
Copy link
Contributor

          We seem to have some redundancy with those tests...

Both QBFT and types/partialSig tests pretty much concentrate on the outer-wrapper msg.Validate() function and pretty much test the same thing.

In ssv with the MsgProcessingSpecTest we pretty much do the same checks all over again, just in the context of the entire processing.

We need to have a discussion on how we do this properly...
Do we want to have those MsgSpecTest check all the validation cases and have another test that proves that the Validate function is called?
Maybe we can have only MsgProcessingTests?

Originally posted by @GalRogozinski in #441 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant