Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

we printed errors instead of returning them #460

Open
GalRogozinski opened this issue Jul 10, 2024 · 2 comments
Open

we printed errors instead of returning them #460

GalRogozinski opened this issue Jul 10, 2024 · 2 comments

Comments

@GalRogozinski
Copy link
Contributor

On instance.Start()
Perhaps we should have proper errors with tests?

Originally posted by @GalRogozinski in #371 (comment)
@GalRogozinski GalRogozinski mentioned this issue Jul 10, 2024
Open
@GalRogozinski
Copy link
Contributor Author

If we propagate the error from instance.start() then it will "return instance failed to start"...
But this isn't true...
not sure how to solve this...
maybe we should just delete the prints?

@y0sher
Copy link
Contributor

y0sher commented Jul 10, 2024

I think it makes more sense that Start can return an error than print.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@y0sher @GalRogozinski