Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yamllint action #72

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .github/workflows/yamllint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
---
name: 'Yamllint GitHub Actions'

# yamllint disable-line rule:truthy
on: [push, pull_request]

jobs:
yamllint:
name: 'Yamllint'
runs-on: ubuntu-latest
steps:
- name: 'Checkout'
uses: actions/checkout@v3.5.3
- name: 'Yamllint'
uses: karancode/yamllint-github-action@v2.1.1
with:
yamllint_file_or_dir: '.'
yamllint_config_filepath: './.yamllint'
yamllint_strict: false
yamllint_comment: true
10 changes: 10 additions & 0 deletions .yamllint
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
extends: default

rules:
# 150 chars should be enough, but don't fail if a line is longer
line-length:
max: 180
level: warning
truthy:
allowed-values: ['true', 'false', 'True', 'False', 'yes', 'no']
2 changes: 1 addition & 1 deletion meta/main.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
galaxy_info:
#role_name: libvirt_host
# role_name: libvirt_host
author: Mark Goddard
description: >
Role to install and configure a host as a Libvirt/KVM hypervisor
Expand Down
2 changes: 0 additions & 2 deletions tasks/rbd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,3 @@

- name: Flush handlers
meta: flush_handlers


2 changes: 1 addition & 1 deletion vars/Archlinux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
libvirt_host_libvirt_packages_default:
- libvirt
- qemu-headless
- ebtables
- ebtables
- dnsmasq

# List of default client packages to install.
Expand Down
6 changes: 3 additions & 3 deletions vars/RedHat.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ libvirt_host_libvirt_packages_client_default:
# Packages that are only necessary if you require EFI support
libvirt_host_packages_efi_by_version:
7:
- edk2.git-ovmf-x64 # Official OVMF package doesn't boot (CentOS 7.5)
- qemu-kvm-ev # Need smm support for secure boot
- edk2.git-ovmf-x64 # Official OVMF package doesn't boot (CentOS 7.5)
- qemu-kvm-ev # Need smm support for secure boot
8:
- edk2-ovmf
9:
Expand Down Expand Up @@ -67,4 +67,4 @@ libvirt_host_lineinfile_extra_rules:
insertafter: '^#LIBVIRTD_ARGS='
regexp: '^LIBVIRTD_ARGS='
line: LIBVIRTD_ARGS="{{ libvirt_host_libvirtd_args }}"
condition: "{{ libvirt_host_libvirtd_args != '' }}"
condition: "{{ libvirt_host_libvirtd_args != '' }}"