-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2023.1] Fix eswitchd and neutron_mlnx_agent not using our fork #1326
Open
jovial
wants to merge
4
commits into
stackhpc/2023.1
Choose a base branch
from
bugfix/2023.1/eswitchd-not-using-fork
base: stackhpc/2023.1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems to work:
|
jovial
force-pushed
the
bugfix/2023.1/eswitchd-not-using-fork
branch
from
October 16, 2024 09:36
5033a5e
to
9541bce
Compare
@jovial how tested are these containers? |
These are running and working at the client already :) |
The neutron_mlnx_agent based containers are not using the neutron plugins, so we need to customize the pip package directly.
MoteHue
force-pushed
the
bugfix/2023.1/eswitchd-not-using-fork
branch
from
October 17, 2024 14:25
9541bce
to
0aaa255
Compare
MoteHue
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @jovial is just double-checking things at the client then he'll merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The neutron_mlnx_agent based containers are not using the neutron plugins, so we need to customize the pip package directly.