Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2023.1] Fix eswitchd and neutron_mlnx_agent not using our fork #1326

Open
wants to merge 4 commits into
base: stackhpc/2023.1
Choose a base branch
from

Conversation

jovial
Copy link
Contributor

@jovial jovial commented Oct 11, 2024

The neutron_mlnx_agent based containers are not using the neutron plugins, so we need to customize the pip package directly.

@jovial
Copy link
Contributor Author

jovial commented Oct 11, 2024

@jovial
Copy link
Contributor Author

jovial commented Oct 11, 2024

Seems to work:

()[neutron@4aa917cba88e /]$ /var/lib/kolla/venv/bin/pip freeze | grep mlnx
networking-mlnx @ git+https://github.com/stackhpc/networking-mlnx@6065fdbeb0e5f842732f2dbc2948af3be46dc776

@jovial jovial force-pushed the bugfix/2023.1/eswitchd-not-using-fork branch from 5033a5e to 9541bce Compare October 16, 2024 09:36
@jovial jovial marked this pull request as ready for review October 16, 2024 17:46
@jovial jovial requested a review from a team as a code owner October 16, 2024 17:46
@Alex-Welsh
Copy link
Contributor

@jovial how tested are these containers?

@MoteHue
Copy link
Contributor

MoteHue commented Oct 17, 2024

@jovial how tested are these containers?

These are running and working at the client already :)

jovial and others added 4 commits October 17, 2024 15:25
The neutron_mlnx_agent based containers are not using the neutron plugins, so we need to customize the pip package directly.
@MoteHue MoteHue force-pushed the bugfix/2023.1/eswitchd-not-using-fork branch from 9541bce to 0aaa255 Compare October 17, 2024 14:25
Copy link
Contributor

@MoteHue MoteHue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @jovial is just double-checking things at the client then he'll merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants