Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce false positive matches by reducing the similarity distance #494

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Reduce false positive matches by reducing the similarity distance #494

merged 1 commit into from
Jan 7, 2025

Conversation

ptelang
Copy link
Contributor

@ptelang ptelang commented Jan 6, 2025 •
edited
Loading

Related to #475 #462

jhrozek
jhrozek previously approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to ack this and lean on your testing but in the future we should have automated tests that should tell us if a set of queries gives the expected results.

@ptelang ptelang force-pushed the reduce-false-positives branch from 6b54bcf to a735435 Compare January 6, 2025 20:47
@ptelang ptelang force-pushed the reduce-false-positives branch from a735435 to 013e96d Compare January 6, 2025 20:52
@ptelang ptelang requested a review from jhrozek January 6, 2025 21:04
@ptelang ptelang merged commit 38e0c96 into main Jan 7, 2025
2 of 3 checks passed
@ptelang ptelang deleted the reduce-false-positives branch January 7, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhrozek jhrozek jhrozek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ptelang @jhrozek