feat: improve cache system to collect the last output #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrobla
requested review from
aponcedeleonch and
peppescg
and removed request for
aponcedeleonch
yrobla
force-pushed
the
issue-472-v2
branch
2 times, most recently
from
6e1a31f to
ae24a59
Compare
Due to the cache system, we were collecting only the initial output of fim, that was including incomplete output. Add an update method to the cache, so we can collect all the output that comes from fim, associated to the same request Closes: #472
peppescg
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the cache system, we were collecting only the initial output of fim, that was including incomplete output. Add an update method to the cache, so we can collect all the output that comes from fim, associated to the same request
Closes: #472