Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sqlc and its classes #515

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Remove sqlc and its classes #515

merged 1 commit into from
Jan 9, 2025

Conversation

aponcedeleonch
Copy link
Contributor

@aponcedeleonch aponcedeleonch commented Jan 8, 2025 •
edited
Loading

Closes: #512

This PR drops sqlc related-files and adds the needed code to use directly SQLAlchemy. In most parts of the code we were already using it, hence the changes are not so drastic. See #512 issue for the reasoining on why to remove sqlc.

@aponcedeleonch
Remove sqlc and its classes
a5de607 
Closes: #512

This PR drops sqlc related-files and adds the needed code to use
directly SQLAlchemy. It most parts of the code we were already using it,
hence the changes are not so drastic. See #512 issue for the reasoining
on why to remove `sqlc`.
@aponcedeleonch aponcedeleonch requested a review from yrobla January 8, 2025 15:07
lukehinds
lukehinds approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@lukehinds lukehinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. we might want to look at introducing connection pools , but not important as its one-to-one, but might help when their are a lot of prompts / outputs occuring with a high frequency.

@lukehinds lukehinds merged commit c23a481 into main Jan 9, 2025
2 checks passed
@lukehinds lukehinds deleted the issue-512 branch January 9, 2025 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukehinds lukehinds lukehinds approved these changes

@yrobla yrobla Awaiting requested review from yrobla

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Evaluate SQL approach - sqlc or raw approach
2 participants
@aponcedeleonch @lukehinds