Add build-arg in make image-build command
#578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build-arg prevents that the step for downloading the UI code is cached. This way we can ensure that we are always using the latest releasee from the UI when building the image locally. The build-arg is already present in the GH action to build and publish the image. Additionally, remove the `secret` provided to the GH action to build the image. It was used when the containers were not public
JAORMX
approved these changes
Jan 14, 2025
peppescg
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build-arg prevents that the step for downloading the UI code is cached. This way we can ensure that we are always using the latest releasee from the UI when building the image locally. The build-arg is already present in the GH action to build and publish the image.
Additionally, remove the
secretprovided to the GH action to build the image. It was used when the containers were not public