Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestNatsChannel test is flaky #4312

Closed
eleftherias opened this issue Aug 29, 2024 · 1 comment
Closed

TestNatsChannel test is flaky #4312

eleftherias opened this issue Aug 29, 2024 · 1 comment
Assignees
@evankanderson
Labels
P1 Fix Soon: High priority items that should be considered in the next Sprint planning cycle

Comments

@eleftherias
Copy link
Contributor

The TestNatsChannel test is inconsistently failing.
Failure example: https://github.com/stacklok/minder/actions/runs/10610301617/job/29407533319
Success example: https://github.com/stacklok/minder/actions/runs/10610294403/job/29407511948

Failure reason:

  make: *** [.mk/test.mk:32: test-silent] Error 1
      natschannel_test.go:96: Got {"msg":"hello"} from out1
      natschannel_test.go:101: timeout waiting for message 2
@eleftherias eleftherias added the P1 Fix Soon: High priority items that should be considered in the next Sprint planning cycle label Aug 29, 2024
jhrozek added a commit to jhrozek/minder that referenced this issue Sep 2, 2024
@jhrozek
Skip the flaky NATS test until it's fixed
e4d7ebe 
Related: mindersec#4312
@jhrozek jhrozek mentioned this issue Sep 2, 2024
Merged
10 tasks
JAORMX pushed a commit that referenced this issue Sep 3, 2024
@jhrozek
Skip the flaky NATS test until it's fixed (#4344)
af631f3 
Related: #4312
@evankanderson
Copy link
Member

Fixed fairly conclusively in #4841

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evankanderson evankanderson

Labels
P1 Fix Soon: High priority items that should be considered in the next Sprint planning cycle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eleftherias @evankanderson