Skip to content

Commit

Permalink
ROX-18000: Upgrade Node to last LTS (#1106)
Browse files Browse the repository at this point in the history
  • Loading branch information
tommartensen authored Dec 20, 2023
1 parent 2adbae9 commit c254251
Show file tree
Hide file tree
Showing 7 changed files with 20 additions and 13 deletions.
8 changes: 8 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,11 @@ updates:
day: 'wednesday'
reviewers:
- 'stackrox/infra'

- package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: 'weekly'
day: 'wednesday'
reviewers:
- "stackrox/infra"
4 changes: 2 additions & 2 deletions .github/workflows/PR.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -80,12 +80,12 @@ jobs:
path: go/src/github.com/stackrox/infra

- name: Authenticate to GCloud
uses: google-github-actions/auth@v0
uses: google-github-actions/auth@v2
with:
credentials_json: ${{ secrets.GCP_INFRA_CI_AUTOMATION_SA }}

- name: Set up Cloud SDK
uses: "google-github-actions/setup-gcloud@v0"
uses: "google-github-actions/setup-gcloud@v2"
with:
install_components: "gke-gcloud-auth-plugin"

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/create-cost-report.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ jobs:
uses: actions/checkout@v3

- name: Authenticate to GCloud
uses: google-github-actions/auth@v0
uses: google-github-actions/auth@v2
with:
credentials_json: ${{ secrets.GCP_BIGQUERY_INFRA_LOGGER_SA }}

- name: 'Set up Cloud SDK'
uses: 'google-github-actions/setup-gcloud@v0'
uses: 'google-github-actions/setup-gcloud@v2'

- name: Install requirements
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/deploy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,12 @@ jobs:
ref: ${{ inputs.version }}

- name: Authenticate to GCloud
uses: google-github-actions/auth@v0
uses: google-github-actions/auth@v2
with:
credentials_json: ${{ secrets.GCP_INFRA_DEPLOY_AUTOMATION_SA }}

- name: 'Set up Cloud SDK'
uses: 'google-github-actions/setup-gcloud@v0'
uses: 'google-github-actions/setup-gcloud@v2'
with:
install_components: "gke-gcloud-auth-plugin"

Expand Down
2 changes: 1 addition & 1 deletion image/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ COPY . .

RUN make server cli

FROM node:16.20.2 as ui-builder
FROM node:20.10.0 as ui-builder

COPY ui ui

Expand Down
7 changes: 3 additions & 4 deletions ui/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,9 @@ about the available scripts and the tooling behavior.
One easy route to current stackrox build tooling is to use
https://github.com/stackrox/stackrox-env.

- [Node.js](https://nodejs.org/en/) `10.15.3 LTS` or higher (it's highly
recommended to use an LTS version, if you're managing multiple versions of
Node.js on your machine, consider using
[nvm](https://github.com/creationix/nvm))
- [Node.js](https://nodejs.org/en/) `20 LTS` or higher (it's highly recommended
to use an LTS version, if you're managing multiple versions of Node.js on your
machine, consider using [nvm](https://github.com/creationix/nvm))
- [Yarn](https://yarnpkg.com/en/)

### GitHub Packages NPM Registry
Expand Down
4 changes: 2 additions & 2 deletions ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@
"clean:tailwind": "rm -f src/index.css",
"start": "npm-run-all clean -p start:*",
"start:tailwind": "NODE_ENV=development postcss ./src/app.tw.css -o ./src/index.css -w",
"start:cra": "wait-on src/index.css && PORT=3001 HTTPS=true EXTEND_ESLINT=true react-scripts start",
"start:cra": "wait-on src/index.css && PORT=3001 HTTPS=true NODE_OPTIONS=--openssl-legacy-provider EXTEND_ESLINT=true react-scripts start",
"build": "npm-run-all build:tailwind build:cra",
"build:tailwind": "NODE_ENV=production postcss ./src/app.tw.css -o ./src/index.css",
"build:cra": "EXTEND_ESLINT=true react-scripts build",
"build:cra": "NODE_OPTIONS=--openssl-legacy-provider EXTEND_ESLINT=true react-scripts build",
"test": "react-scripts test",
"eject": "react-scripts eject",
"lint-check": "npm-run-all lint-check:*",
Expand Down

0 comments on commit c254251

Please sign in to comment.