From c2542518294840550dd837d1e5b5562a5fe90b16 Mon Sep 17 00:00:00 2001 From: Tom Martensen Date: Wed, 20 Dec 2023 08:42:22 +0100 Subject: [PATCH] ROX-18000: Upgrade Node to last LTS (#1106) --- .github/dependabot.yml | 8 ++++++++ .github/workflows/PR.yaml | 4 ++-- .github/workflows/create-cost-report.yaml | 4 ++-- .github/workflows/deploy.yaml | 4 ++-- image/Dockerfile | 2 +- ui/README.md | 7 +++---- ui/package.json | 4 ++-- 7 files changed, 20 insertions(+), 13 deletions(-) diff --git a/.github/dependabot.yml b/.github/dependabot.yml index 4d32fd7b6..8f8f846b4 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -29,3 +29,11 @@ updates: day: 'wednesday' reviewers: - 'stackrox/infra' + + - package-ecosystem: "github-actions" + directory: "/" + schedule: + interval: 'weekly' + day: 'wednesday' + reviewers: + - "stackrox/infra" diff --git a/.github/workflows/PR.yaml b/.github/workflows/PR.yaml index c88c48bc6..87954020a 100644 --- a/.github/workflows/PR.yaml +++ b/.github/workflows/PR.yaml @@ -80,12 +80,12 @@ jobs: path: go/src/github.com/stackrox/infra - name: Authenticate to GCloud - uses: google-github-actions/auth@v0 + uses: google-github-actions/auth@v2 with: credentials_json: ${{ secrets.GCP_INFRA_CI_AUTOMATION_SA }} - name: Set up Cloud SDK - uses: "google-github-actions/setup-gcloud@v0" + uses: "google-github-actions/setup-gcloud@v2" with: install_components: "gke-gcloud-auth-plugin" diff --git a/.github/workflows/create-cost-report.yaml b/.github/workflows/create-cost-report.yaml index b71245f0e..d20e8c319 100644 --- a/.github/workflows/create-cost-report.yaml +++ b/.github/workflows/create-cost-report.yaml @@ -11,12 +11,12 @@ jobs: uses: actions/checkout@v3 - name: Authenticate to GCloud - uses: google-github-actions/auth@v0 + uses: google-github-actions/auth@v2 with: credentials_json: ${{ secrets.GCP_BIGQUERY_INFRA_LOGGER_SA }} - name: 'Set up Cloud SDK' - uses: 'google-github-actions/setup-gcloud@v0' + uses: 'google-github-actions/setup-gcloud@v2' - name: Install requirements run: | diff --git a/.github/workflows/deploy.yaml b/.github/workflows/deploy.yaml index 96c3c3491..df47263bc 100644 --- a/.github/workflows/deploy.yaml +++ b/.github/workflows/deploy.yaml @@ -38,12 +38,12 @@ jobs: ref: ${{ inputs.version }} - name: Authenticate to GCloud - uses: google-github-actions/auth@v0 + uses: google-github-actions/auth@v2 with: credentials_json: ${{ secrets.GCP_INFRA_DEPLOY_AUTOMATION_SA }} - name: 'Set up Cloud SDK' - uses: 'google-github-actions/setup-gcloud@v0' + uses: 'google-github-actions/setup-gcloud@v2' with: install_components: "gke-gcloud-auth-plugin" diff --git a/image/Dockerfile b/image/Dockerfile index 88e41a5ee..e0c849a36 100644 --- a/image/Dockerfile +++ b/image/Dockerfile @@ -6,7 +6,7 @@ COPY . . RUN make server cli -FROM node:16.20.2 as ui-builder +FROM node:20.10.0 as ui-builder COPY ui ui diff --git a/ui/README.md b/ui/README.md index efa93efd1..09284adf0 100644 --- a/ui/README.md +++ b/ui/README.md @@ -16,10 +16,9 @@ about the available scripts and the tooling behavior. One easy route to current stackrox build tooling is to use https://github.com/stackrox/stackrox-env. -- [Node.js](https://nodejs.org/en/) `10.15.3 LTS` or higher (it's highly - recommended to use an LTS version, if you're managing multiple versions of - Node.js on your machine, consider using - [nvm](https://github.com/creationix/nvm)) +- [Node.js](https://nodejs.org/en/) `20 LTS` or higher (it's highly recommended + to use an LTS version, if you're managing multiple versions of Node.js on your + machine, consider using [nvm](https://github.com/creationix/nvm)) - [Yarn](https://yarnpkg.com/en/) ### GitHub Packages NPM Registry diff --git a/ui/package.json b/ui/package.json index cd2939d6f..577159fce 100644 --- a/ui/package.json +++ b/ui/package.json @@ -7,10 +7,10 @@ "clean:tailwind": "rm -f src/index.css", "start": "npm-run-all clean -p start:*", "start:tailwind": "NODE_ENV=development postcss ./src/app.tw.css -o ./src/index.css -w", - "start:cra": "wait-on src/index.css && PORT=3001 HTTPS=true EXTEND_ESLINT=true react-scripts start", + "start:cra": "wait-on src/index.css && PORT=3001 HTTPS=true NODE_OPTIONS=--openssl-legacy-provider EXTEND_ESLINT=true react-scripts start", "build": "npm-run-all build:tailwind build:cra", "build:tailwind": "NODE_ENV=production postcss ./src/app.tw.css -o ./src/index.css", - "build:cra": "EXTEND_ESLINT=true react-scripts build", + "build:cra": "NODE_OPTIONS=--openssl-legacy-provider EXTEND_ESLINT=true react-scripts build", "test": "react-scripts test", "eject": "react-scripts eject", "lint-check": "npm-run-all lint-check:*",