Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-20252: add rosa hcp option #1053

Merged
merged 106 commits into from
Dec 22, 2023
Merged

ROX-20252: add rosa hcp option #1053

merged 106 commits into from
Dec 22, 2023

Conversation

davdhacs
Copy link
Contributor

@davdhacs davdhacs commented Oct 27, 2023

Adds flavor option to infra for ROSA HCP.
image

@ghost
Copy link

ghost commented Oct 27, 2023

A single node development cluster (infra-pr-1053) was allocated in production infra for this PR.

CI will attempt to deploy us.gcr.io/stackrox-infra/infra-server:0.8.7-18-g4a505fc3dc to it.

🔌 You can connect to this cluster with:

gcloud container clusters get-credentials infra-pr-1053 --zone us-central1-a --project acs-team-temp-dev

🛠️ And pull infractl from the deployed dev infra-server with:

nohup kubectl -n infra port-forward svc/infra-server-service 8443:8443 &
make pull-infractl-from-dev-server

🚲 You can then use the dev infra instance e.g.:

bin/infractl -k -e localhost:8443 whoami

⚠️ Any clusters that you start using your dev infra instance should have a lifespan shorter then the development cluster instance. Otherwise they will not be destroyed when the dev infra instance ceases to exist when the development cluster is deleted. ⚠️

Further Development

☕ If you make changes, you can commit and push and CI will take care of updating the development cluster.

🚀 If you only modify configuration (chart/infra-server/configuration) or templates (chart/infra-server/{static,templates}), you can get a faster update with:

make install-local

Logs

Logs for the development infra depending on your @redhat.com authuser:

Or:

kubectl -n infra logs -l app=infra-server --tail=1 -f

@rhacs-bot
Copy link
Contributor

rhacs-bot commented Nov 22, 2023

A single node development cluster (infra-pr-1053) was allocated in production infra for this PR.

CI will attempt to deploy us.gcr.io/stackrox-infra/infra-server:0.8.8-124-ga20dcf86b2 to it.

🔌 You can connect to this cluster with:

gcloud container clusters get-credentials infra-pr-1053 --zone us-central1-a --project acs-team-temp-dev

🛠️ And pull infractl from the deployed dev infra-server with:

nohup kubectl -n infra port-forward svc/infra-server-service 8443:8443 &
make pull-infractl-from-dev-server

🚲 You can then use the dev infra instance e.g.:

bin/infractl -k -e localhost:8443 whoami

⚠️ Any clusters that you start using your dev infra instance should have a lifespan shorter then the development cluster instance. Otherwise they will not be destroyed when the dev infra instance ceases to exist when the development cluster is deleted. ⚠️

Further Development

☕ If you make changes, you can commit and push and CI will take care of updating the development cluster.

🚀 If you only modify configuration (chart/infra-server/configuration) or templates (chart/infra-server/{static,templates}), you can get a faster update with:

make install-local

Logs

Logs for the development infra depending on your @redhat.com authuser:

Or:

kubectl -n infra logs -l app=infra-server --tail=1 -f

@davdhacs davdhacs marked this pull request as ready for review December 19, 2023 20:34
@davdhacs davdhacs requested a review from a team as a code owner December 19, 2023 20:34
Comment on lines 779 to 784
- name: managed-cp
description: Use managed control-plane?
value: "false"
kind: optional
help: |
Run as ROSA HCP?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this parameter be exposed to the user?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure. I like showing that both ROSA flavors are the same, but with different default values. But it may just be confusing? I wondered if I should reset the ROSA flavor to be the same as it was before this change(?).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think it is confusing now, because you could set Use Managed Control Plane to true in classic ROSA - what would the effect be?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, you can change the arguments in the rosa flavor form to match the defaults in the hcp/hypershift form and you'll get a matching cluster. So it just provides different default settings, and the managed_cp toggles hypershift on/off.

Copy link
Contributor

@gavin-stackrox gavin-stackrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit/suggestion for help formatting, but otherwise LGTM.

chart/infra-server/static/flavors.yaml Outdated Show resolved Hide resolved
Co-authored-by: Gavin Jefferies <gjefferi@redhat.com>
@davdhacs davdhacs merged commit 554a0f7 into master Dec 22, 2023
7 checks passed
@davdhacs davdhacs deleted the ROX-20252-add-rosa-hcp-option branch December 22, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants