More refactorings #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove `freetype-rs` dependency - use (unpublished) one from sdf_glyph_renderer * get rid of all panics (unwraps) * add proper thiserror-based errors * cleanup exports to be on the same top level
* combine_glyphs should not double-check hashset for values * combine_glyphs doesn't need to have two extra iterations to compute min/max * combine_glyphs should return None per docs on empty
|
closing this in favor of #13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code requires stadiamaps/sdf_glyph_renderer#7
freetype-rsdependency - use (unpublished) one from sdf_glyph_renderercombine_glyphsshould not double-check hashset for valuescombine_glyphsdoesn't need to have two extra iterations to compute min/maxcombine_glyphsshould return None per docs on empty