Housekeeping #17
Merged
Housekeeping #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lseelenbinder
approved these changes
Feb 12, 2024
|
sorry, got swamped, will review shortly too |
nyurik
reviewed
Feb 12, 2024
.github/workflows/ci.yml
Outdated
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: taiki-e/install-action@cargo-hack |
There was a problem hiding this comment.
This is fine, but just in case you would want to extend this, I found this syntax cleaner as it allows multiple tools
Suggested change
| - uses: taiki-e/install-action@cargo-hack | |
| - uses: taiki-e/install-action@v2 | |
| with: { tool: cargo-hack } |
build_pbf_glyphs/src/main.rs
Outdated
| use pbf_font_tools::freetype::{Face, Library}; | ||
| use pbf_font_tools::{get_named_font_stack, glyph_range_for_face, Glyphs}; | ||
| use protobuf::{CodedOutputStream, Message}; | ||
| use spmc::{channel, Receiver}; | ||
|
|
||
| static TOTAL_GLYPHS_RENDERED: AtomicUsize = AtomicUsize::new(0); | ||
|
|
||
| #[derive(Parser, Debug)] | ||
| #[command(version, author, about, long_about = None)] |
There was a problem hiding this comment.
why do you need long_about = None ?
There was a problem hiding this comment.
Because I misread the docs, apparently 😂 Removing...
build_pbf_glyphs/src/main.rs
Outdated
| #[command(version, author, about, long_about = None)] | ||
| struct Args { | ||
| /// Sets the source directory to be scanned for fonts. | ||
| font_dir: String, |
There was a problem hiding this comment.
You don't want to use String here - all paths are better used with PathBuf -- Clap supports them just fine
There was a problem hiding this comment.
Ahh TIL Clap supports those!
build_pbf_glyphs/src/main.rs
Outdated
| let overwrite = matches.is_present("OVERWRITE"); | ||
| let args = Args::parse(); | ||
|
|
||
| let font_dir = Path::new(&args.font_dir); |
There was a problem hiding this comment.
you won't need to convert stuff to path if you start with PathBuf above
nyurik
reviewed
Feb 13, 2024
| let overwrite = matches.is_present("OVERWRITE"); | ||
| let args = Args::parse(); | ||
|
|
||
| let font_dir = &args.font_dir; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bunch of minor housekeeping