Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for arm64 image #505

Closed
gothka opened this issue Jul 10, 2023 · 10 comments
Closed

Support for arm64 image #505

gothka opened this issue Jul 10, 2023 · 10 comments
Assignees
Labels
kind/enhancement New feature or request kind/help wanted Extra attention is needed stale

Comments

@gothka
Copy link

gothka commented Jul 10, 2023

Hi, i'm checking to see if there's any plan to start supporting arm64 builds for the controller image as i couldn't any tag that supports that on docker hub. I'm happy to submit a PR :)

@MuneebAijaz MuneebAijaz added kind/enhancement New feature or request kind/help wanted Extra attention is needed labels Jul 19, 2023
@MuneebAijaz
Copy link
Contributor

hi @gothka , would you like to submit a PR for the suggested change? We do have binaries pushed for some architectures, but images are based on one arch

@tuxpeople
Copy link

I'm interested as well, but can't do a pr as I don't know anything about goreleaser, which you are using for the releases. I've only experience building multi-arch images using the docker or buildah actions.

@gothka I'm happy to test arm64 once you have such an image

tuxpeople added a commit to tuxpeople/k8s-homelab that referenced this issue Jul 20, 2023
@github-actions
Copy link

This issue is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the stale label Sep 19, 2023
@nohant
Copy link
Contributor

nohant commented Oct 3, 2023

yeah, we need that too, i think it should also need some edit on the github action because here:

      uses: docker/build-push-action@v4
      with:
        context: .
        file: ${{ env.DOCKER_FILE_PATH  }}
        pull: true
        push: true
        cache-to: type=inline
        tags: |
          ${{ env.IMAGE_REPOSITORY }}:${{ steps.generate_tag.outputs.new_tag }}
        labels: |
          org.opencontainers.image.source=${{ github.event.repository.clone_url }}
          org.opencontainers.image.created=${{ steps.prep.outputs.created }}
          org.opencontainers.image.revision=${{ github.sha }}

its only setting the default version. But by the look of it, the build version is configurer inside the dockerfile here:
RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 GO111MODULE=on go build -mod=mod -a -o manager main.go

@nohant
Copy link
Contributor

nohant commented Oct 3, 2023

@tuxpeople I'm sorry, you have to build locally from the branch, the default pipeline don't build for arm.
Thanks for your eventual time.

@github-actions github-actions bot removed the stale label Oct 4, 2023
@bnallapeta bnallapeta self-assigned this Oct 4, 2023
@nohant
Copy link
Contributor

nohant commented Oct 10, 2023

May i help in any other way?
its been a week and we would like to use this component in our arm cluster.

@bnallapeta
Copy link

@nohant I will take a look at this and get back to you soon.

@bnallapeta
Copy link

@nohant I just replied on #526. Please check.

bnallapeta pushed a commit that referenced this issue Oct 12, 2023
feat(#505): enable default multi-arch build
Copy link

This issue is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the stale label Dec 10, 2023
@MuneebAijaz
Copy link
Contributor

#526 i suppose issue was fixed in the mentioned PR, please reopen the issue if any concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request kind/help wanted Extra attention is needed stale
Projects
None yet
Development

No branches or pull requests

5 participants