Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#505): enable default multi-arch build #526

Merged
merged 5 commits into from
Oct 12, 2023
Merged

feat(#505): enable default multi-arch build #526

merged 5 commits into from
Oct 12, 2023

Conversation

nohant
Copy link
Contributor

@nohant nohant commented Oct 3, 2023

this is done as a basic configuration for #505
the build is correctly working on my host but i dont know how to test it more :(

the part of the github action i think should be discussed or at least taken care of by someone more expert than me

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

@nohant Image is available for testing. docker pull stakater/ingressmonitorcontroller:SNAPSHOT-PR-526-a3c36478

@bnallapeta
Copy link

@nohant
Instead of having different tags for different platforms for the images, it is easier on the user to just have the same tag and let docker figure out the platform.
If you take a look at our Reloader images, we have done this already by having the same tag with multi-platform support.
Could you please follow the same standard here too? The changes here look mostly right except the Docker push step. You can refer to this one for reference.

@nohant
Copy link
Contributor Author

nohant commented Oct 10, 2023

@bnallapeta you are right im sorry, im too used to how we do that.
Now it should work the same as you said in the other configurations.

@bnallapeta
Copy link

@nohant Its still not generating multi arch images. I am checking on this. Will get back to you.

@nohant
Copy link
Contributor Author

nohant commented Oct 11, 2023

@bnallapeta don't worry mate, I'm sure i've forgot something :D
thanks for the help, really appreciate.

@nohant nohant requested a review from bnallapeta October 12, 2023 08:08
@nohant
Copy link
Contributor Author

nohant commented Oct 12, 2023

fixed all the request points, sorry for the matrix leftover.

@bnallapeta bnallapeta merged commit 619ad2a into stakater:master Oct 12, 2023
1 check passed
@bnallapeta
Copy link

bnallapeta commented Oct 12, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants