Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For grafana monitor, fixes bug with invalid tenant ID #567

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

thunef
Copy link
Contributor

@thunef thunef commented Jan 15, 2024

There was an issue with Grafana synthetic monitoring which resulted in these errors:

{"level":"error","ts":1704550886.2006788,"logger":"gcloud-monitor","msg":"Failed to update monitor","error":"check update request: status=\"400 Bad Request\", msg=\"Invalid tenantId for user\", err=\"bad request\"","stacktrace":"github.com/stakater/IngressMonitorController/v2/pkg/monitors/grafana.(*GrafanaMonitorService).Update\n\t/workspace/pkg/monitors/grafana/grafana-monitor.go:146\ngithub.com/stakater/IngressMonitorController/v2/pkg/monitors.(*MonitorServiceProxy).Update\n\t/workspace/pkg/monitors/monitor-proxy.go:101\ngithub.com/stakater/IngressMonitorController/v2/pkg/controllers.(*EndpointMonitorReconciler).handleUpdate\n\t/workspace/pkg/controllers/endpointmonitor_updated.go:26\ngithub.com/stakater/IngressMonitorController/v2/pkg/controllers.

The reason was that tenant was picked from config when it should be picked from the actual check

@thunef thunef changed the title For grafana monitor, check update now uses tenant ID from existing check For grafana monitor, fixes bug with invalid tenant ID Jan 15, 2024
Copy link

github-actions bot commented Jan 15, 2024

@thunef Image is available for testing. docker pull stakater/ingressmonitorcontroller:SNAPSHOT-PR-567-2ae20043

@thunef thunef force-pushed the thunef/grafana-check-update-tenant-fix branch 7 times, most recently from 9912c5a to a3e3e4b Compare January 16, 2024 14:59
@thunef thunef force-pushed the thunef/grafana-check-update-tenant-fix branch from a3e3e4b to 2ae2004 Compare January 16, 2024 15:05
@thunef thunef merged commit 5a01726 into master Jan 17, 2024
1 check passed
@thunef thunef deleted the thunef/grafana-check-update-tenant-fix branch January 17, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants