Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collision add-on unaware of get/set methods? #79

Open
canadaduane opened this issue Apr 6, 2020 · 5 comments
Open

Collision add-on unaware of get/set methods? #79

canadaduane opened this issue Apr 6, 2020 · 5 comments

Comments

@canadaduane
Copy link

canadaduane commented Apr 6, 2020

I have a stamp with a method that uses get style function:

  methods: {
    /**
     * @returns {string}
     */
    get label() {
      return this.state.label.target
    },
    ...

I also have a few methods that I am trying to set up for defer style collision so that they are all called (instead of the last one).

It appears that when I use these two features together, I get an error that this.state is undefined. Using console.trace I am lead believe that this line of code is "calling" my getter:

https://github.com/stampit-org/stamp/blob/master/packages/collision/index.js#L146

@koresar
Copy link
Member

koresar commented Apr 6, 2020 via email

@koresar
Copy link
Member

koresar commented Apr 6, 2020

Oh! I see now. It calls the getter. Shite! 😀
That's definitely a big. Thank you for reporting.
It's clear how to reproduce.

@canadaduane
Copy link
Author

Ha! Yes, that's the one. Thanks for taking a look.

@canadaduane
Copy link
Author

Is this something that you have time to fix? I just ran into this issue again.

@koresar
Copy link
Member

koresar commented Jun 14, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants