Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Typescript continues... #78

Open
wants to merge 66 commits into
base: master
Choose a base branch
from
Open

Conversation

PopGoesTheWza
Copy link
Contributor

No description provided.

@PopGoesTheWza
Copy link
Contributor Author

PopGoesTheWza commented Mar 5, 2020

@koresar resuming work on this repo... still unfinished

Something (minor) is probably wrong for my latest pushes aren't linked to my GitHub profile...

@koresar
Copy link
Member

koresar commented May 13, 2020

Hey @PopGoesTheWza
I've just pushed a commit to this branch with my improvements on the TS typings.
Tell me if that's not OK.

Next thing I'm thinking - add TS annotations to the object instances created from stamps with help of generics. (I might fail here.)

@PopGoesTheWza
Copy link
Contributor Author

Hello,
I hope you're fine.
I've been a hell of a lot busy with family, work and contributing to sindre's Got.

I want to get back on stampit's TS asap though not yet sure when. Meanwhile I gained more experience with TS typing which I intend to put in good use here. ;)

@koresar
Copy link
Member

koresar commented May 14, 2020

I added generics to the @stamp/types package. Would need to test thoroughly before committing.

@PopGoesTheWza
Copy link
Contributor Author

@koresar FYI, I am heavily into refactoring the type system. I hope to have it done within a week.

@koresar
Copy link
Member

koresar commented Mar 7, 2021

@koresar FYI, I am heavily into refactoring the type system. I hope to have it done within a week.

No worries. Looks great so far. Tell me if you need something. E.g. merging to master or whatever.

@PopGoesTheWza
Copy link
Contributor Author

@koresar if one can provide simple to complex examples, preferably covering all packages... to tests/verify both typing e execution. ;)

@koresar
Copy link
Member

koresar commented Mar 9, 2021

The examples are here: https://github.com/stampit-org/stamp/tree/master/packages/check-compose
Both complex and simple.

Also, here are some examples for "@stamp/it" package only: https://github.com/stampit-org/stampit/tree/master/test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants