Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collision: Expand defer into map/reduce, add support for initializer aggregation, aggregating asynchronous methods and be backwards compatible. #80

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Collision: Expand defer into map/reduce, add support for initializer aggregation, aggregating asynchronous methods and be backwards compatible. #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
84d0069
Collision: Expand defer into map/reduce, support async and be backwar…
sammys Mar 31, 2021
d26c000
makeReduceThisAsyncProxyFunction proxy should be named reduceThisAsyncFn
sammys Apr 1, 2021
9764f03
Collision: Add null as possible return type for prepareSettings()
sammys Apr 2, 2021
423aef6
Collision: Finish implementation of hasAggregates(), getAggregates() …
sammys Apr 3, 2021
144b009
Collision: Re-enable no-shadow for repo-wide eslint
sammys Apr 4, 2021
fbfce62
Collision: Add getDomainItems() and getDomainItem()
sammys Apr 4, 2021
5588619
Collision: Revert @typescript-eslint/* back to 2.15 (same as master)
sammys Apr 4, 2021
a422b21
Collision: Revert compose/index.ts to master implementation (and adhe…
sammys Apr 4, 2021
a31b3f1
Collision: Add tests for sync/async initializers throwing at any part…
sammys Apr 5, 2021
ef07428
Collision: Typos in latest jest mockNames
sammys Apr 5, 2021
01ff260
Dedupe aggregated initializers
sammys May 7, 2021
77d443f
Initializer-specific async reducer function + tests
sammys May 11, 2021
8bc93ec
Allow collisionSetAggregates to have any functions not just subset of…
sammys Jun 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion __tests__/privatize-plus-collision.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ describe('Collision + Privatize', function () {
var PrivateDraw = Privatize.privatizeMethods('draw');

// General purpose behavior to forbid the "redraw()" method collision
var ForbidRedrawCollision = Collision.collisionSetup({forbid: ['redraw']});
var ForbidRedrawCollision = Collision.collisionSetup({methods: { forbid: ['redraw'] } });

// The aggregating component
var ModalDialog = compose(PrivateDraw) // privatize the "draw()" method
Expand Down
Loading