Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace checkmate::expect_* with checkmate::assert_* outside tests #330

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

n-kall
Copy link
Collaborator

@n-kall n-kall commented Dec 14, 2023

Summary

As stated in #329, testthat is currently an unlisted dependency due to checkmate::expect_* usage. This changes the code to checkmate::assert_* which was likely the original intention.

Copyright and Licensing

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@paul-buerkner
Copy link
Collaborator

Thanks! Merging.

@paul-buerkner paul-buerkner merged commit c79a40d into stan-dev:master Dec 14, 2023
9 of 10 checks passed
Copy link

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 1adfce7 is merged into master:

  •   :rocket:as_draws_array: 101ms -> 100ms [-1.27%, -0.05%]
  • ❗🐌as_draws_df: 32ms -> 32.7ms [+0.89%, +3.47%]
  •   :ballot_box_with_check:as_draws_list: 189ms -> 192ms [-1.06%, +4.27%]
  •   :rocket:as_draws_matrix: 32ms -> 30.9ms [-4.87%, -2.01%]
  •   :ballot_box_with_check:as_draws_rvars: 157ms -> 155ms [-2.45%, +0.88%]
  • ❗🐌summarise_draws_100_variables: 716ms -> 721ms [+0.07%, +1.2%]
  •   :ballot_box_with_check:summarise_draws_10_variables: 78.9ms -> 78.7ms [-0.69%, +0.19%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants