Enable call to PreparedStatement's cancel

[BagusThanatos]

Metabase calls PreparedStatement's .cancel method in order to stop any queries cancelled by the user as shown here
https://github.com/metabase/metabase/blob/ceacccd0b1aa4dc51c0c88228f91922fe6934ec0/src/metabase/driver/sql_jdbc/execute.clj#L735

We observed that it failed to cancel with java.lang.UnsupportedOperationException which looks like due to cancel function not currently proxied.

Any feedback is appreciated as I'm not familiar with clojure and this is my first interaction with Metabase codebase.

Thank you

[lpoulain]

Would you mind rebasing your PR?

[BagusThanatos]

Would you mind rebasing your PR?

Sure, no problem.

[BagusThanatos]

@lpoulain Rebase done.

[lpoulain]

@BagusThanatos thanks a lot. Now, I'm trying to reproduce the issue on the latest branch but cannot get the error you describe. I created a question with a text variable (to force the use of prepared statement) and canceled the query but get no error. Are you using a different method?

[BagusThanatos]

@BagusThanatos thanks a lot. Now, I'm trying to reproduce the issue on the latest branch but cannot get the error you describe. I created a question with a text variable (to force the use of prepared statement) and canceled the query but get no error. Are you using a different method?

@lpoulain For the error to be logged, I had to modify Metabase source code as below, as it only logged statement cancellation failed.

Also, if this Optimized Prepared Statement was enabled, adding it here if it matters

[lpoulain]

I ran some tests and it works fine. However, for the sake of completeness, (cancel [] (.cancel stmt)) should also be added to proxy-prepared-statement and sql-jdbc.execute/statement. You can either add them to your PR or I can file my own PR with all three additions.

[BagusThanatos]

I ran some tests and it works fine. However, for the sake of completeness, (cancel [] (.cancel stmt)) should also be added to proxy-prepared-statement and sql-jdbc.execute/statement. You can either add them to your PR or I can file my own PR with all three additions.

I've updated the PR, and would appreciate it if you can confirm whether it's the correct place(s).
Thanks!