Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard Account Interface #27

Merged
merged 7 commits into from
Oct 2, 2023

Conversation

ericnordelo
Copy link
Contributor

This proposes a SNIP for standardizing the account interface that different accountors (OZ, Argent, and Braavos) have been using. This standard affects the interface that is used with introspection for recognizing accounts in modules like ERC721 and ERC1155 from OZ.

@github-actions
Copy link

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale label Aug 30, 2023
@ericnordelo
Copy link
Contributor Author

ericnordelo commented Sep 1, 2023

Since the PR will be closed, maybe is worth merging it even when the Rationale has not been added yet? cc @martriay @abdelhamidbakhta

@martriay
Copy link
Collaborator

martriay commented Sep 1, 2023

+1 to merging it, as a standard it's quite settled and the DRAFT status is enough. no need to keep the PR open if progress is slow, and there's value in having it displayed to the community for integrations.

@github-actions github-actions bot removed the stale label Sep 2, 2023
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale label Oct 2, 2023
@ericnordelo
Copy link
Contributor Author

Should we merge this? cc @abdelhamidbakhta @ArielElp

@AbdelStark AbdelStark marked this pull request as ready for review October 2, 2023 16:00
@AbdelStark AbdelStark merged commit dae80cb into starknet-io:main Oct 2, 2023
1 check failed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants