Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update snip-2 token standard #28

Merged
merged 2 commits into from
Jul 28, 2023
Merged

Update snip-2 token standard #28

merged 2 commits into from
Jul 28, 2023

Conversation

moodysalem
Copy link
Contributor

@moodysalem moodysalem commented Jul 10, 2023 •
edited
Loading

Updates for cairo v2 and removes allowance methods that are not applicable to starknet

Looking for feedback on:

  • removing approvals/allowance/transferFrom
  • removing the returned bool of transfer (this will be problematic if people check it currently)

@moodysalem moodysalem changed the title Update snip-2.md Update snip-2 token standard Jul 19, 2023
AbdelStark
AbdelStark approved these changes Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@AbdelStark AbdelStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AbdelStark AbdelStark merged commit 58af75f into starknet-io:main Jul 28, 2023
1 check failed
@moodysalem moodysalem deleted the patch-1 branch July 28, 2023 19:36
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AbdelStark AbdelStark AbdelStark approved these changes

@ArielElp ArielElp Awaiting requested review from ArielElp ArielElp is a code owner

@bbrandtom bbrandtom Awaiting requested review from bbrandtom bbrandtom is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moodysalem @AbdelStark