From 304d76dfabfcdf3d8efbb2f183fe0c4cc69d9f96 Mon Sep 17 00:00:00 2001
From: NaorYe <naor@starkware.co>
Date: Wed, 26 Jun 2024 16:48:32 +0300
Subject: [PATCH] - Fix tests

---
 packages/core/src/__test__/main.test.ts       |  2 +-
 packages/core/src/__test__/wallet.mock.ts     | 30 ++++++++++++-------
 .../core/src/wallet/virtualWallets/index.ts   |  2 +-
 3 files changed, 22 insertions(+), 12 deletions(-)

diff --git a/packages/core/src/__test__/main.test.ts b/packages/core/src/__test__/main.test.ts
index dffdd73..a242172 100644
--- a/packages/core/src/__test__/main.test.ts
+++ b/packages/core/src/__test__/main.test.ts
@@ -131,7 +131,7 @@ describe("getDiscoveryWallets()", () => {
   it("should return all discovery wallets", async () => {
     const sn = getWallet({})
     const discoveryWallets = await sn.getDiscoveryWallets()
-    expect(discoveryWallets.length).toBe(2)
+    expect(discoveryWallets.length).toBe(3)
     expect(discoveryWallets.map((w) => w.id)).contains(ArgentXMock.id)
     expect(discoveryWallets.map((w) => w.id)).contains(BraavosMock.id)
   })
diff --git a/packages/core/src/__test__/wallet.mock.ts b/packages/core/src/__test__/wallet.mock.ts
index 91a2215..70c5a12 100644
--- a/packages/core/src/__test__/wallet.mock.ts
+++ b/packages/core/src/__test__/wallet.mock.ts
@@ -1,23 +1,28 @@
 import wallets from "../discovery"
 import { Permission, type StarknetWindowObject } from "@starknet-io/types-js"
 
-type WalletMock = Pick<StarknetWindowObject, "id" | "name" | "icon" | "request">
-
-export const UnknownWalletAMock: WalletMock = {
+export const UnknownWalletAMock: StarknetWindowObject = {
   id: "wallet-a",
   name: "Wallet A",
+  version: "0.0.0",
   icon: "https://avatars.dicebear.com/api/initials/Wallet%20A.svg",
   request: async () => false,
+  on: () => {},
+  off: () => {},
 }
-export const UnknownWalletBMock: WalletMock = {
+export const UnknownWalletBMock: StarknetWindowObject = {
   id: "wallet-b",
   name: "Wallet B",
+  version: "0.0.0",
   icon: "https://avatars.dicebear.com/api/initials/Wallet%20B.svg",
   request: async () => false,
+  on: () => {},
+  off: () => {},
 }
 
-export const ArgentXMock: WalletMock = {
+export const ArgentXMock: StarknetWindowObject = {
   ...wallets.find((w) => w.id === "argentX")!,
+  version: "0.0.0",
   request: async (request) => {
     switch (request.type) {
       case "wallet_getPermissions":
@@ -26,10 +31,13 @@ export const ArgentXMock: WalletMock = {
         return undefined as any
     }
   },
+  on: () => {},
+  off: () => {},
 }
 
-export const BraavosMock: WalletMock = {
+export const BraavosMock: StarknetWindowObject = {
   ...wallets.find((w) => w.id === "braavos")!,
+  version: "0.0.0",
   request: async (request) => {
     switch (request.type) {
       case "wallet_getPermissions":
@@ -38,10 +46,12 @@ export const BraavosMock: WalletMock = {
         return undefined as any
     }
   },
+  on: () => {},
+  off: () => {},
 }
 
 export function makeAuthorized(authorized: boolean) {
-  return (wallet: WalletMock) =>
+  return (wallet: StarknetWindowObject) =>
     ({
       ...wallet,
       request: async (request) => {
@@ -52,11 +62,11 @@ export function makeAuthorized(authorized: boolean) {
             return wallet.request(request)
         }
       },
-    } as WalletMock)
+    } as StarknetWindowObject)
 }
 
 export function makeConnected(isConnected: boolean) {
-  return (wallet: WalletMock) => {
+  return (wallet: StarknetWindowObject) => {
     return {
       ...makeAuthorized(true)(wallet),
       request: async ({ type }) => {
@@ -67,6 +77,6 @@ export function makeConnected(isConnected: boolean) {
             return []
         }
       },
-    } as WalletMock
+    } as StarknetWindowObject
   }
 }
diff --git a/packages/core/src/wallet/virtualWallets/index.ts b/packages/core/src/wallet/virtualWallets/index.ts
index cb5913c..a7d5288 100644
--- a/packages/core/src/wallet/virtualWallets/index.ts
+++ b/packages/core/src/wallet/virtualWallets/index.ts
@@ -1,6 +1,6 @@
 import type { VirtualWallet } from "../../types"
 import { metaMaskVirtualWallet } from "./metaMaskVirtualWallet"
-import type { StarknetWindowObject } from "starknet-types"
+import type { StarknetWindowObject } from "@starknet-io/types-js"
 
 const virtualWallets: VirtualWallet[] = [metaMaskVirtualWallet]