Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: wallet_deploymentData #205

Closed
wants to merge 2 commits into from
Closed

feat: wallet_deploymentData #205

wants to merge 2 commits into from

Conversation

janek26
Copy link
Member

@janek26 janek26 commented Nov 21, 2023

No description provided.

leo-starkware
leo-starkware approved these changes Nov 23, 2023
View reviewed changes
Copy link

@leo-starkware leo-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I would possibly add a comment on sigdata that you would always return an empty string

leo-starkware
leo-starkware reviewed Nov 24, 2023
View reviewed changes
Copy link

@leo-starkware leo-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should also be a Cairo version field

@avimak
Copy link
Collaborator

avimak commented Dec 6, 2023

@janek26 - pls reply here/over there https://community.starknet.io/t/snip-deployment-interface-between-dapps-and-wallets/101923/9?u=avimak

@dan-ziv
Copy link
Contributor

dan-ziv commented Mar 3, 2024 •
edited
Loading

@janek26, before we proceed with the merge, could you please address the following issues:

  • The wallet_deploymentData call has the potential to return null.
  • The version field is returned from the request. Therefore, it should be included in the type definition.

Thank you for looking into these matters.

@avimak
Copy link
Collaborator

avimak commented Mar 3, 2024

@dan-ziv pls check #194 which also covers for this request (and is already merged)

@avimak
Copy link
Collaborator

avimak commented Mar 28, 2024

@janek26 perhaps we could close this one, now that #194 has been merged

@dan-ziv
Copy link
Contributor

dan-ziv commented Apr 15, 2024 •
edited
Loading

#194 Already covers this PR.

@dan-ziv dan-ziv closed this Apr 15, 2024
@dan-ziv dan-ziv deleted the feature/wallet-deploymentData branch June 26, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leo-starkware leo-starkware leo-starkware approved these changes

@diegodelrieu diegodelrieu diegodelrieu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@janek26 @avimak @dan-ziv @diegodelrieu @leo-starkware