Improvements of core exports #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm, @dhruvkelawala if no objections pls merge 👍 |
avimak
approved these changes
Mar 27, 2024
dhruvkelawala
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dhruvkelawala
(info : @ivpavici )
core,StarknetChainIdandPermissionare enums.Permissionis exported as enum, butStarknetChainIdis exported as type.To be able to use correctly
StarknetChainId, it's proposed to export it also as an enum.WalletAccountclass in a DAPP, it appeared that it's beneficial for DAPP devs to be able to importscanObjectForWallets&isWalletObj. It's proposed to add these 2 exports in core.