chore: rename EntryPointExecutionContext::new_invoke to new_execute #220
Conversation
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tdelabro)
a discussion (no related file):
I agree that new_execute is a much better name than new_invoke, but I am not convinced it is a good name, as we use the name 'execute' in numerous contexts in our code. Maybe new_validation and new_execution will better indicate that these are execution modes.
tdelabro
force-pushed
the
rename-EntryPointExecutionContext-new_validate
branch
from
399696e
to
63b9d2d
Compare
|
@meship-starkware done |
There was a problem hiding this comment.
Reviewed 6 of 6 files at r3.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @tdelabro)
|
There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. |
fixes: starkware-libs/blockifier#1761
This change is