refactor(blockifier_reexecution): set chain ID by inspecting RPC URL #1973
+39
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This was referenced Nov 12, 2024
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @dorimedini-starkware and the rest of your teammates on |
This was referenced Nov 12, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 11-12-refactor_blockifier_reexecution_add_chain_id_to_serializableofflinereexecutiondata #1973 +/- ##
===========================================================================================================================
Coverage ? 41.58%
===========================================================================================================================
Files ? 198
Lines ? 23441
Branches ? 23441
===========================================================================================================================
Hits ? 9749
Misses ? 13235
Partials ? 457 ☔ View full report in Codecov by Sentry. |
dorimedini-starkware
force-pushed
the
11-12-refactor_blockifier_reexecution_add_chain_id_to_serializableofflinereexecutiondata
branch
from
c4c7ff2
to
a4d664b
Compare
dorimedini-starkware
force-pushed
the
11-12-refactor_blockifier_reexecution_set_chain_id_by_inspecting_rpc_url
branch
from
fb4736b
to
f729381
Compare
dorimedini-starkware
force-pushed
the
11-12-refactor_blockifier_reexecution_add_chain_id_to_serializableofflinereexecutiondata
branch
from
a4d664b
to
74cb405
Compare
dorimedini-starkware
force-pushed
the
11-12-refactor_blockifier_reexecution_set_chain_id_by_inspecting_rpc_url
branch
from
f729381
to
69a7f44
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
dorimedini-starkware
force-pushed
the
11-12-refactor_blockifier_reexecution_set_chain_id_by_inspecting_rpc_url
branch
from
69a7f44
to
773ca69
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @aner-starkware and @graphite-app[bot])
dorimedini-starkware
force-pushed
the
11-12-refactor_blockifier_reexecution_add_chain_id_to_serializableofflinereexecutiondata
branch
from
74cb405
to
141a523
Compare
dorimedini-starkware
force-pushed
the
11-12-refactor_blockifier_reexecution_set_chain_id_by_inspecting_rpc_url
branch
from
773ca69
to
78e7e2b
Compare
AvivYossef-starkware
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @aner-starkware and @graphite-app[bot])
dorimedini-starkware
force-pushed
the
11-12-refactor_blockifier_reexecution_add_chain_id_to_serializableofflinereexecutiondata
branch
from
141a523
to
0c076ba
Compare
dorimedini-starkware
force-pushed
the
11-12-refactor_blockifier_reexecution_set_chain_id_by_inspecting_rpc_url
branch
from
78e7e2b
to
174825a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.