Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(blockifier): use sierra version in native blockifier #2809

Merged

Conversation

AvivYossef-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

@AvivYossef-starkware AvivYossef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add python PR

Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware)


a discussion (no related file):
blocking, pending python PR


crates/blockifier/src/execution/contract_class.rs line 311 at r1 (raw file):

    pub fn try_from_json_string(
        (raw_contract_class, sierra_version): (&str, SierraVersion),

why tuple and not two params? non-blocking

Suggestion:

 raw_contract_class: &str, sierra_version: SierraVersion

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/use_sierra_version_in_native_blockifier branch from 18c18b1 to 1c1fd9d Compare December 19, 2024 09:35
Copy link
Contributor Author

@AvivYossef-starkware AvivYossef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)


a discussion (no related file):

Previously, dorimedini-starkware wrote…

blocking, pending python PR

python pr


crates/blockifier/src/execution/contract_class.rs line 311 at r1 (raw file):

Previously, dorimedini-starkware wrote…

why tuple and not two params? non-blocking

Its a good question
lol

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/refactor_blockifier_contract_class branch from a040553 to 87285bf Compare December 19, 2024 10:17
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/use_sierra_version_in_native_blockifier branch from 1c1fd9d to 09c392b Compare December 19, 2024 10:17
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/refactor_blockifier_contract_class branch 2 times, most recently from 4022be4 to 0b19960 Compare December 19, 2024 11:39
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/use_sierra_version_in_native_blockifier branch from 09c392b to 2553415 Compare December 19, 2024 11:39
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/refactor_blockifier_contract_class branch from 0b19960 to 5d8e938 Compare December 19, 2024 13:21
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/use_sierra_version_in_native_blockifier branch from 2553415 to 46b65f0 Compare December 19, 2024 13:22
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/refactor_blockifier_contract_class branch from 5d8e938 to e6dbb02 Compare December 19, 2024 13:49
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/use_sierra_version_in_native_blockifier branch from 46b65f0 to facff36 Compare December 19, 2024 13:49
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/refactor_blockifier_contract_class branch 2 times, most recently from 3b35f20 to f88449c Compare December 19, 2024 16:06
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/use_sierra_version_in_native_blockifier branch from facff36 to 850718f Compare December 19, 2024 16:06
@AvivYossef-starkware AvivYossef-starkware changed the base branch from aviv/refactor_blockifier_contract_class to graphite-base/2809 December 22, 2024 07:37
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/use_sierra_version_in_native_blockifier branch from 850718f to 1aff2fe Compare December 22, 2024 07:37
@AvivYossef-starkware AvivYossef-starkware changed the base branch from graphite-base/2809 to main December 22, 2024 07:38
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/use_sierra_version_in_native_blockifier branch from 1aff2fe to 48c5672 Compare December 22, 2024 07:38
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

@AvivYossef-starkware AvivYossef-starkware merged commit 44b01f9 into main Dec 22, 2024
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants