test(sequencing): serialize compiled_contract_class to the central object

[Yael-Starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[Yael-Starkware]

• test(sequencing): fix central bouncer weights test #3348
• test(sequencing): serialize compiled_contract_class to the central object #3115 👈 (View in Graphite)
• test(sequencing): test sierra contract class serialization #3039
• feat(consensus): add declare transaction for cende #2921 : 1 other dependent PR (#2988 )
• feat(sequencing): add cetral deploy account transaction written object #2872
• feat(consensus): add central invoke transaction #2861
• feat(consensus): add CentralStateDiff object in the aerospike format #2715
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Artifacts upload workflows:

• Started at 2025-01-05T12:16:40Z
• Started at 2025-01-07T12:57:43Z
• Started at 2025-01-07T12:59:52Z
• Started at 2025-01-08T13:17:06Z
• Started at 2025-01-08T15:39:42Z
• Started at 2025-01-13T09:54:35Z
• Started at 2025-01-15T14:39:47Z
• Started at 2025-01-16T06:41:34Z
• Started at 2025-01-16T06:41:34Z

[DvirYo-starkware]

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dafnamatsry and @Yael-Starkware)

---

crates/sequencing/papyrus_consensus_orchestrator/src/cende/central_objects.rs line 295 at r1 (raw file):

// Converts the CasmContractClass into a format that serializes into the python object.
// TODO remove allow dead code once used

Add an explicit name to make sure it is not forgotten

Code quote:

// TODO remove allow dead code once used

---

crates/sequencing/papyrus_consensus_orchestrator/src/cende/central_objects.rs line 298 at r1 (raw file):

#[allow(dead_code)]
pub fn casm_contract_class_central_format(
    compiled_class_hash: CasmContractClass,

Does this code mean that in the Rust version, the fields bytecode_segment_lengths and pythonic_hints can be None, but in the Python version, they must be some value? If so, please write this explicitly.

[Yael-Starkware]

Reviewable status: 5 of 6 files reviewed, 1 unresolved discussion (waiting on @dafnamatsry and @DvirYo-starkware)

---

crates/sequencing/papyrus_consensus_orchestrator/src/cende/central_objects.rs line 295 at r1 (raw file):

Previously, DvirYo-starkware wrote…

Add an explicit name to make sure it is not forgotten

done.

---

crates/sequencing/papyrus_consensus_orchestrator/src/cende/central_objects.rs line 298 at r1 (raw file):

Previously, DvirYo-starkware wrote…

Does this code mean that in the Rust version, the fields bytecode_segment_lengths and pythonic_hints can be None, but in the Python version, they must be some value? If so, please write this explicitly.

Done.

[DvirYo-starkware]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry)

[dafnamatsry]

Reviewed 2 of 4 files at r3, all commit messages.
Reviewable status: 4 of 6 files reviewed, 2 unresolved discussions (waiting on @DvirYo-starkware and @Yael-Starkware)

---

crates/sequencing/papyrus_consensus_orchestrator/src/cende/central_objects_test.rs line 65 at r3 (raw file):

pub const CENTRAL_SIERRA_CONTRACT_CLASS_JSON_PATH: &str = "central_sierra_contract_class.json";
pub const CENTRAL_CASM_CONTRACT_CLASS_JSON_PATH: &str = "central_contract_class.casm.json";
pub const CENTRAL_CASM_CONTRACT_CLASS_NO_OPTIONAL_JSON_PATH: &str =

What is the difference in the content of these files?

Code quote:

pub const CENTRAL_CASM_CONTRACT_CLASS_JSON_PATH: &str = "central_contract_class.casm.json";
pub const CENTRAL_CASM_CONTRACT_CLASS_NO_OPTIONAL_JSON_PATH: &str =

---

crates/sequencing/papyrus_consensus_orchestrator/src/cende/central_objects.rs line 359 at r3 (raw file):

    CasmContractClass {
        // The rust object allows these fields to be none, while in python they are mandatory.
        bytecode_segment_lengths: Some(

What happens if we deserialize a JSON without those fields in Python?
would it fail? would it put default values?

[Yael-Starkware]

Reviewable status: 4 of 6 files reviewed, 2 unresolved discussions (waiting on @dafnamatsry and @DvirYo-starkware)

---

crates/sequencing/papyrus_consensus_orchestrator/src/cende/central_objects.rs line 359 at r3 (raw file):

Previously, dafnamatsry wrote…

What happens if we deserialize a JSON without those fields in Python?
would it fail? would it put default values?

fail.

---

crates/sequencing/papyrus_consensus_orchestrator/src/cende/central_objects_test.rs line 65 at r3 (raw file):

Previously, dafnamatsry wrote…

What is the difference in the content of these files?

the second json has an empty vector for pythonic_hints and bytecode_segment_lengths

[dafnamatsry]

Reviewed 2 of 6 files at r1, 2 of 4 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Yael-Starkware)

---

crates/sequencing/papyrus_consensus_orchestrator/src/cende/central_objects_test.rs line 65 at r3 (raw file):

Previously, Yael-Starkware (YaelD) wrote…

the second json has an empty vector for pythonic_hints and bytecode_segment_lengths

The name of the constant is misleading I think.
Maybe rename it to CENTRAL_CASM_CONTRACT_CLASS_DEFAULT_OPTIONALS_JSON_PATH

[Yael-Starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dafnamatsry)

---

crates/sequencing/papyrus_consensus_orchestrator/src/cende/central_objects_test.rs line 65 at r3 (raw file):

Previously, dafnamatsry wrote…

The name of the constant is misleading I think.
Maybe rename it to CENTRAL_CASM_CONTRACT_CLASS_DEFAULT_OPTIONALS_JSON_PATH

Done.

[dafnamatsry]

Reviewed 6 of 6 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Yael-Starkware)

[github-actions]

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [35.431 ms 35.672 ms 35.956 ms]
change: [+2.4200% +3.1770% +4.1361%] (p = 0.00 < 0.05)
Performance has regressed.
Found 13 outliers among 100 measurements (13.00%)
3 (3.00%) high mild
10 (10.00%) high severe

full_committer_flow performance regressed!
full_committer_flow time: [31.018 ms 31.090 ms 31.167 ms]
change: [+1.7455% +2.0000% +2.2980%] (p = 0.00 < 0.05)
Performance has regressed.
Found 5 outliers among 100 measurements (5.00%)
3 (3.00%) high mild
2 (2.00%) high severe

[DvirYo-starkware]

Reviewable status: 4 of 6 files reviewed, all discussions resolved (waiting on @dafnamatsry)

[DvirYo-starkware]

Reviewed 4 of 6 files at r6, 2 of 2 files at r7, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Yael-Starkware)