chore(starknet_infra_utils): remove get_available_socket #3323
Conversation
|
This change is |
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)
crates/starknet_sequencer_infra/src/tests/remote_component_client_server_test.rs line 69 at r1 (raw file):
// Define the shared fixture static AVAILABLE_PORTS: Lazy<Arc<Mutex<AvailablePorts>>> = Lazy::new(|| {
Why not using tokio::sync::Mutex?
Code quote:
MutexThere was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware)
crates/starknet_sequencer_infra/src/tests/remote_component_client_server_test.rs line 69 at r1 (raw file):
Previously, nadin-Starkware (Nadin Jbara) wrote…
Why not using tokio::sync::Mutex?
It is, look at the import
use tokio::sync::Mutex;
Itay-Tsabary-Starkware
force-pushed
the
spr/main/0e96c675
branch
from
95f893b to
c205446
Compare
Itay-Tsabary-Starkware
force-pushed
the
spr/main/3470ac8e
branch
from
3ee1ee3 to
0acb17a
Compare
Itay-Tsabary-Starkware
force-pushed
the
spr/main/0e96c675
branch
2 times, most recently
from
b0e4e28 to
6c9eccd
Compare
Itay-Tsabary-Starkware
changed the base branch from
spr/main/3470ac8e
to
main
Itay-Tsabary-Starkware
force-pushed
the
spr/main/0e96c675
branch
from
6c9eccd to
6079450
Compare
Itay-Tsabary-Starkware
force-pushed
the
spr/main/0e96c675
branch
from
6079450 to
2db0172
Compare
There was a problem hiding this comment.
Reviewable status: 3 of 5 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)
crates/starknet_sequencer_infra/src/tests/remote_component_client_server_test.rs line 69 at r1 (raw file):
Previously, Itay-Tsabary-Starkware wrote…
It is, look at the import
use tokio::sync::Mutex;
Oops
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)
There was a problem hiding this comment.
Reviewed 3 of 5 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status:
Itay-Tsabary-Starkware
force-pushed
the
spr/main/0e96c675
branch
2 times, most recently
from
7df070e to
1660baa
Compare
|
Benchmark movements: |
Itay-Tsabary-Starkware
force-pushed
the
spr/main/0e96c675
branch
2 times, most recently
from
b38f0ec to
39f6139
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:
Itay-Tsabary-Starkware
force-pushed
the
spr/main/0e96c675
branch
from
39f6139 to
8775ce1
Compare
Itay-Tsabary-Starkware
changed the base branch from
main
to
spr/main/93899d3c
Itay-Tsabary-Starkware
changed the base branch from
spr/main/93899d3c
to
main
Itay-Tsabary-Starkware
force-pushed
the
spr/main/0e96c675
branch
from
8775ce1 to
c6574dd
Compare
|
Benchmark movements: |
Itay-Tsabary-Starkware
force-pushed
the
spr/main/0e96c675
branch
from
c6574dd to
bd91722
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status:
commit-id:0e96c675
Itay-Tsabary-Starkware
force-pushed
the
spr/main/0e96c675
branch
from
bd91722 to
a8472b0
Compare
|
Benchmark movements: |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status:
|
✓ Commit merged in pull request #3342 |
Stack: