Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(sequencing): fix central bouncer weights test #3348

Merged
merged 1 commit into from
Jan 19, 2025

Conversation

Yael-Starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@Yael-Starkware Yael-Starkware marked this pull request as ready for review January 15, 2025 14:45
@Yael-Starkware Yael-Starkware force-pushed the yael/central_compiled_contract_class branch 2 times, most recently from 00a4cd9 to c4d7077 Compare January 16, 2025 14:19
@Yael-Starkware Yael-Starkware force-pushed the yael/fix_bouncer_weights_test branch from 44a595b to 5cfbc07 Compare January 16, 2025 14:20
Copy link
Contributor

@DvirYo-starkware DvirYo-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

I think this is fine. I will wait for @dafnamatsry because she supports this approach.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry)

Copy link
Collaborator

@dafnamatsry dafnamatsry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Yael-Starkware)

@Yael-Starkware Yael-Starkware changed the base branch from yael/central_compiled_contract_class to main January 19, 2025 13:43
@Yael-Starkware Yael-Starkware force-pushed the yael/fix_bouncer_weights_test branch from 5cfbc07 to 6adca8d Compare January 19, 2025 13:46
@Yael-Starkware Yael-Starkware added this pull request to the merge queue Jan 19, 2025
Merged via the queue into main with commit fa1e4b3 Jan 19, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants