Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(starknet_class_manager_types): add MemoryClassManagerClient for testing #3351

Conversation

noamsp-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@noamsp-starkware noamsp-starkware force-pushed the noam.s/add_memory_class_manager_client branch from 4968431 to 09a68da Compare January 15, 2025 15:40
@noamsp-starkware noamsp-starkware changed the title test(starknet_class_manager_types): MemoryClassManagerClient for testing test(starknet_class_manager_types): add MemoryClassManagerClient for testing Jan 15, 2025
@noamsp-starkware noamsp-starkware force-pushed the noam.s/add_class_manager_client_to_p2p_sync_server branch from e5ae6d0 to 2d724db Compare January 15, 2025 15:52
@noamsp-starkware noamsp-starkware force-pushed the noam.s/add_memory_class_manager_client branch from 09a68da to 13e458c Compare January 15, 2025 15:52
@noamsp-starkware noamsp-starkware force-pushed the noam.s/add_class_manager_client_to_p2p_sync_server branch from 2d724db to 3fc2de3 Compare January 16, 2025 09:18
@noamsp-starkware noamsp-starkware force-pushed the noam.s/add_memory_class_manager_client branch from 13e458c to 3aba1f9 Compare January 16, 2025 09:18
@noamsp-starkware noamsp-starkware marked this pull request as ready for review January 16, 2025 09:33
Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @elintul and @noamsp-starkware)


crates/starknet_class_manager_types/src/test_utils.rs line 22 at r1 (raw file):

pub struct MemoryClassManagerClient {
    sierras: Arc<Mutex<HashMap<ClassHash, SierraContractClass>>>,
    contracts: Arc<Mutex<HashMap<ClassHash, ExecutableClass>>>,

contracts -> casms

@noamsp-starkware noamsp-starkware force-pushed the noam.s/add_class_manager_client_to_p2p_sync_server branch from 3fc2de3 to 2f0c23c Compare January 16, 2025 13:28
@noamsp-starkware noamsp-starkware force-pushed the noam.s/add_memory_class_manager_client branch from 3aba1f9 to 3f00cd6 Compare January 16, 2025 13:28
Copy link
Contributor Author

@noamsp-starkware noamsp-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dismissed @ShahakShama from a discussion.
Reviewable status: 2 of 3 files reviewed, all discussions resolved (waiting on @elintul and @ShahakShama)


crates/starknet_class_manager_types/src/test_utils.rs line 22 at r1 (raw file):

Previously, ShahakShama wrote…

contracts -> casms

Done.

Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @elintul)


crates/starknet_class_manager_types/src/test_utils.rs line 22 at r1 (raw file):

Previously, noamsp-starkware wrote…

Done.

You changed the wrong line. It should be sierras and casms

Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @elintul and @noamsp-starkware)

@noamsp-starkware noamsp-starkware force-pushed the noam.s/add_class_manager_client_to_p2p_sync_server branch from 2f0c23c to 1e057b6 Compare January 19, 2025 10:22
@noamsp-starkware noamsp-starkware force-pushed the noam.s/add_memory_class_manager_client branch from 3f00cd6 to 76419bc Compare January 19, 2025 10:22
Copy link
Contributor Author

@noamsp-starkware noamsp-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @elintul and @ShahakShama)


crates/starknet_class_manager_types/src/test_utils.rs line 22 at r1 (raw file):

Previously, ShahakShama wrote…

You changed the wrong line. It should be sierras and casms

Sorry, my bad

Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @elintul)

@noamsp-starkware noamsp-starkware merged commit c7350d6 into noam.s/add_class_manager_client_to_p2p_sync_server Jan 19, 2025
15 of 16 checks passed
@noamsp-starkware noamsp-starkware deleted the noam.s/add_memory_class_manager_client branch January 19, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants