-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(starknet_class_manager_types): add MemoryClassManagerClient for testing #3351
test(starknet_class_manager_types): add MemoryClassManagerClient for testing #3351
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
4968431
to
09a68da
Compare
e5ae6d0
to
2d724db
Compare
09a68da
to
13e458c
Compare
2d724db
to
3fc2de3
Compare
13e458c
to
3aba1f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @elintul and @noamsp-starkware)
crates/starknet_class_manager_types/src/test_utils.rs
line 22 at r1 (raw file):
pub struct MemoryClassManagerClient { sierras: Arc<Mutex<HashMap<ClassHash, SierraContractClass>>>, contracts: Arc<Mutex<HashMap<ClassHash, ExecutableClass>>>,
contracts -> casms
3fc2de3
to
2f0c23c
Compare
3aba1f9
to
3f00cd6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dismissed @ShahakShama from a discussion.
Reviewable status: 2 of 3 files reviewed, all discussions resolved (waiting on @elintul and @ShahakShama)
crates/starknet_class_manager_types/src/test_utils.rs
line 22 at r1 (raw file):
Previously, ShahakShama wrote…
contracts -> casms
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @elintul)
crates/starknet_class_manager_types/src/test_utils.rs
line 22 at r1 (raw file):
Previously, noamsp-starkware wrote…
Done.
You changed the wrong line. It should be sierras and casms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @elintul and @noamsp-starkware)
2f0c23c
to
1e057b6
Compare
3f00cd6
to
76419bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @elintul and @ShahakShama)
crates/starknet_class_manager_types/src/test_utils.rs
line 22 at r1 (raw file):
Previously, ShahakShama wrote…
You changed the wrong line. It should be sierras and casms
Sorry, my bad
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @elintul)
c7350d6
into
noam.s/add_class_manager_client_to_p2p_sync_server
No description provided.