-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: move local deps to root toml #362
build: move local deps to root toml #362
Conversation
db75c2a
to
9e7211c
Compare
Benchmark movements: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #362 +/- ##
==========================================
+ Coverage 76.45% 76.48% +0.02%
==========================================
Files 328 328
Lines 34816 34816
Branches 34816 34816
==========================================
+ Hits 26619 26628 +9
+ Misses 5903 5898 -5
+ Partials 2294 2290 -4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)
crates/blockifier/Cargo.toml
line 41 at r1 (raw file):
num-traits.workspace = true once_cell.workspace = true papyrus_config = { workspace = true, version = "0.4.0-rc.0" }
version should be controlled by root cargo toml
Suggestion:
papyrus_config.workspace = true
commit-id:c7e2f0b9
9e7211c
to
51a307c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 4 of 6 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)
crates/blockifier/Cargo.toml
line 41 at r1 (raw file):
Previously, dorimedini-starkware wrote…
version should be controlled by root cargo toml
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 6 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)
Benchmark movements: |
commit-id:c7e2f0b9
This change is