Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: organize methods such that public methods are at bottom #432

Closed
wants to merge 1 commit into from
Closed

chore: organize methods such that public methods are at bottom #432

wants to merge 1 commit into from

Conversation

ArniStarkware
Copy link
Contributor

@ArniStarkware ArniStarkware commented Aug 13, 2024 •
edited by alon-dotan-starkware
Loading

This change is Reviewable

@ArniStarkware Graphite App
Copy link
Contributor Author

ArniStarkware commented Aug 13, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on Graphite Graphite

This was referenced Aug 13, 2024
Closed
Closed
Closed
@ArniStarkware ArniStarkware marked this pull request as ready for review August 13, 2024 14:01
@ArniStarkware ArniStarkware mentioned this pull request Aug 13, 2024
Closed
dafnamatsry
dafnamatsry approved these changes Aug 14, 2024
View reviewed changes
Copy link
Collaborator

@dafnamatsry dafnamatsry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

@ArniStarkware ArniStarkware force-pushed the arni/contract_class_refactor/order_pub_funcs branch 2 times, most recently from 376a76d to 6120a00 Compare August 14, 2024 11:03
@ArniStarkware ArniStarkware mentioned this pull request Aug 14, 2024
Closed
@ArniStarkware ArniStarkware force-pushed the arni/contract_class_refactor/order_pub_funcs branch from 6120a00 to 85e18ed Compare August 18, 2024 06:51
@ArniStarkware
Copy link
Contributor Author

We continue with a different path.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2024
@ArniStarkware ArniStarkware deleted the arni/contract_class_refactor/order_pub_funcs branch October 26, 2024 16:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dafnamatsry dafnamatsry dafnamatsry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArniStarkware @dafnamatsry