feat(blockifier): add native entry point execution #551
Conversation
# Conflicts: # crates/blockifier/src/execution/syscalls/syscalls_test.rs
…-engine # Conflicts: # Cargo.lock
…cution-engine # Conflicts: # Cargo.lock
…cution-engine # Conflicts: # Cargo.lock # crates/blockifier/src/execution/contract_class.rs
There was a problem hiding this comment.
Reviewed 4 of 23 files at r1.
Reviewable status: 4 of 23 files reviewed, all discussions resolved
There was a problem hiding this comment.
Reviewed 16 of 23 files at r1, all commit messages.
Reviewable status: 20 of 23 files reviewed, all discussions resolved
…call-handler # Conflicts: # crates/blockifier/src/execution/native/utils.rs
There was a problem hiding this comment.
Reviewable status: 20 of 23 files reviewed, 1 unresolved discussion (waiting on @varex83)
crates/blockifier/src/execution/native/utils.rs line 87 at r1 (raw file):
storage_read_values: Vec<Felt>, accessed_storage_keys: HashSet<StorageKey, RandomState>, ) -> Result<CallInfo, EntryPointExecutionError> {
Is there a reason for this function to return a Result? It looks like it will always return call info, wouldn't it be better if this function will return CallInfo and the function that calls it will wrap it with Ok?
…-execution # Conflicts: # crates/blockifier/src/execution/native/utils.rs
There was a problem hiding this comment.
Reviewable status: 20 of 23 files reviewed, 1 unresolved discussion (waiting on @meship-starkware)
crates/blockifier/src/execution/native/utils.rs line 87 at r1 (raw file):
Previously, meship-starkware (Meshi Peled) wrote…
Is there a reason for this function to return a Result? It looks like it will always return call info, wouldn't it be better if this function will return CallInfo and the function that calls it will wrap it with Ok?
Yeah, that sounds reasonable, it should be done.
There was a problem hiding this comment.
Reviewed 1 of 4 files at r6, all commit messages.
Reviewable status: 16 of 23 files reviewed, 1 unresolved discussion
There was a problem hiding this comment.
Reviewed 1 of 4 files at r6.
Reviewable status: 17 of 23 files reviewed, 1 unresolved discussion
rodrigo-pino
added
the
native integration
There was a problem hiding this comment.
Reviewed 1 of 4 files at r3, 1 of 7 files at r5, 1 of 4 files at r6, 1 of 1 files at r7.
Reviewable status: 21 of 23 files reviewed, all discussions resolved (waiting on @varex83)
|
Solved in #1158 |
This PR is follow-up after #549
This change is