chore(blockifier): add visited pcs trait to remove add visited pcs fr…

[meship-starkware]

…om state API

---

This change is 

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.27%. Comparing base (b0cfe82) to head (e621c96).
Report is 51 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/blockifier/src/state/state_api.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #821      +/-   ##
==========================================
- Coverage   74.18%   70.27%   -3.91%     
==========================================
  Files         359       87     -272     
  Lines       36240    11120   -25120     
  Branches    36240    11120   -25120     
==========================================
- Hits        26886     7815   -19071     
+ Misses       7220     2917    -4303     
+ Partials     2134      388    -1746     

Flag	Coverage Δ
	70.27% <0.00%> (-3.91%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[meship-starkware]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @noaov1)

---

crates/blockifier/src/state/state_api.rs line 107 at r1 (raw file):

    ) -> StateResult<()>;
}

I am not sure this trait should be here. Do we want to allow other full nodes to use this trait if they want to implement add_visited_pcs of their own?

[noaov1]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @meship-starkware)

---

crates/blockifier/src/state/state_api.rs line 107 at r1 (raw file):
Good point. I think it can stay in this file as it is only used by the State trait.
Do we have a test that uses a State other than the CachedState? (a state that does not implement the add_visited_pcs method)

Do we want to allow other full nodes to use this trait if they want to implement add_visited_pcs of their own?

WDYM?