-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(protobuf): provide an indicative message on protoc prebuilt error #842
chore(protobuf): provide an indicative message on protoc prebuilt error #842
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #842 +/- ##
==========================================
+ Coverage 74.44% 74.45% +0.01%
==========================================
Files 364 364
Lines 38395 38395
Branches 38395 38395
==========================================
+ Hits 28583 28587 +4
+ Misses 7493 7491 -2
+ Partials 2319 2317 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AlonLStarkWare and @eitanm-starkware)
crates/papyrus_protobuf/build.rs
line 7 at r1 (raw file):
println!("Building"); let (protoc_bin, _) = protoc_prebuilt::init("27.0") .expect("Please run gh auth login to enable protoc compilation");
surround the command with ``
c71761b
to
5eaf55c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @eitanm-starkware and @ShahakShama)
crates/papyrus_protobuf/build.rs
line 7 at r1 (raw file):
Previously, ShahakShama wrote…
surround the command with ``
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @eitanm-starkware)
This change is