Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(protobuf): provide an indicative message on protoc prebuilt error #842

Merged

Conversation

AlonLStarkWare
Copy link
Contributor

@AlonLStarkWare AlonLStarkWare commented Sep 17, 2024

This change is Reviewable

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.45%. Comparing base (8aa893b) to head (c71761b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #842      +/-   ##
==========================================
+ Coverage   74.44%   74.45%   +0.01%     
==========================================
  Files         364      364              
  Lines       38395    38395              
  Branches    38395    38395              
==========================================
+ Hits        28583    28587       +4     
+ Misses       7493     7491       -2     
+ Partials     2319     2317       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AlonLStarkWare and @eitanm-starkware)


crates/papyrus_protobuf/build.rs line 7 at r1 (raw file):

    println!("Building");
    let (protoc_bin, _) = protoc_prebuilt::init("27.0")
        .expect("Please run gh auth login to enable protoc compilation");

surround the command with ``

@AlonLStarkWare AlonLStarkWare force-pushed the alonl/provide_indicative_message_on_protoc_prebuilt_error branch from c71761b to 5eaf55c Compare September 18, 2024 08:56
Copy link
Contributor Author

@AlonLStarkWare AlonLStarkWare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @eitanm-starkware and @ShahakShama)


crates/papyrus_protobuf/build.rs line 7 at r1 (raw file):

Previously, ShahakShama wrote…

surround the command with ``

Done.

Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @eitanm-starkware)

@AlonLStarkWare AlonLStarkWare merged commit 158f318 into main Sep 18, 2024
22 checks passed
@AlonLStarkWare AlonLStarkWare deleted the alonl/provide_indicative_message_on_protoc_prebuilt_error branch September 18, 2024 13:50
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants