-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(base_layer): add safe conversion to felt #856
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #856 +/- ##
==========================================
+ Coverage 74.29% 74.31% +0.01%
==========================================
Files 358 358
Lines 36288 36226 -62
Branches 36288 36226 -62
==========================================
- Hits 26960 26921 -39
+ Misses 7190 7167 -23
Partials 2138 2138 ☔ View full report in Codecov by Sentry. |
3f5435f
to
84b3504
Compare
e442280
to
394a974
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dan-starkware and @giladchase)
crates/papyrus_base_layer/src/ethereum_base_layer_contract.rs
line 36 at r1 (raw file):
#[error(transparent)] FeltParseError(#[from] felt::FromStrError), }
Keep alphabetized?
394a974
to
987710e
Compare
23fa49d
to
333cd90
Compare
987710e
to
9f21800
Compare
744efb1
to
1967659
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dan-starkware and @giladchase)
d70e877
to
5637076
Compare
1967659
to
4f0d83f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dan-starkware and @giladchase)
4f0d83f
to
988dae6
Compare
commit-id:a4bb6349
988dae6
to
62d84d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dan-starkware)
commit-id:a4bb6349
Stack:
This change is