refactor(base_layer): remove optional finality

[giladchase]

No finality is equivalent to passing finality 0.

commit-id:2f82d223

---

This change is 

[codecov]

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.29%. Comparing base (7da2d63) to head (dee5efe).
Report is 13 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/papyrus_sync/src/sources/base_layer.rs	0.00%	2 Missing ⚠️
...rus_base_layer/src/ethereum_base_layer_contract.rs	50.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #869   +/-   ##
=======================================
  Coverage   74.29%   74.29%           
=======================================
  Files         358      357    -1     
  Lines       36288    36214   -74     
  Branches    36288    36214   -74     
=======================================
- Hits        26960    26907   -53     
+ Misses       7190     7170   -20     
+ Partials     2138     2137    -1     

Flag	Coverage Δ
	74.29% <25.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[elintul]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @giladchase)

[elintul]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @giladchase)

[elintul]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @giladchase)

[elintul]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @giladchase)

---

crates/papyrus_base_layer/src/ethereum_base_layer_contract.rs line 102 at r4 (raw file):

    async fn latest_proved_block(
        &self,
        finality: u64,

Maybe add a short sentence about 0 signifying "latest"? Might be obvious, so your call.

Code quote:

finality: u64,

[elintul]

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @giladchase)

---

crates/papyrus_base_layer/src/ethereum_base_layer_contract.rs line 100 at r5 (raw file):

    type Error = EthereumBaseLayerError;

    /// Gets the latest proved block on Ethereum, where finality determines how many

Suggestion:

Returns

[elintul]

Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @giladchase)