Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(mempool_infra): change remote server to send messages to loc… #890

Conversation

Itay-Tsabary-Starkware
Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware commented Sep 19, 2024

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.20%. Comparing base (f68bd90) to head (98ecb4e).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #890      +/-   ##
==========================================
+ Coverage   74.18%   74.20%   +0.02%     
==========================================
  Files         359      359              
  Lines       36240    36222      -18     
  Branches    36240    36222      -18     
==========================================
- Hits        26884    26880       -4     
+ Misses       7220     7212       -8     
+ Partials     2136     2130       -6     
Flag Coverage Δ
74.20% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the title refactor(mempool_infra): change remote server to send messages to local server refactor(mempool_infra): change remote server to send messages to loc… Sep 20, 2024
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the pr/Itay-Tsabary-Starkware/tsabary/remote_connetion/7e0d8402 branch from 81df463 to c1ad11c Compare September 20, 2024 12:52
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the title refactor(mempool_infra): change remote server to send messages to loc… refactor(mempool_infra): change remote server to send messages to local server Sep 20, 2024
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the base branch from main to pr/Itay-Tsabary-Starkware/tsabary/remote_connetion/16fb3ec0 September 20, 2024 12:52
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the pr/Itay-Tsabary-Starkware/tsabary/remote_connetion/16fb3ec0 branch from fd623ac to 9e6668d Compare September 21, 2024 21:07
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the pr/Itay-Tsabary-Starkware/tsabary/remote_connetion/7e0d8402 branch from c1ad11c to 171eece Compare September 21, 2024 21:07
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the pr/Itay-Tsabary-Starkware/tsabary/remote_connetion/16fb3ec0 branch from 9e6668d to 96501ce Compare September 22, 2024 06:16
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the pr/Itay-Tsabary-Starkware/tsabary/remote_connetion/7e0d8402 branch from 171eece to c4d0def Compare September 22, 2024 06:16
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the title refactor(mempool_infra): change remote server to send messages to local server refactor(mempool_infra): change remote server to send messages to loc… Sep 22, 2024
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the base branch from pr/Itay-Tsabary-Starkware/tsabary/remote_connetion/16fb3ec0 to main September 22, 2024 06:52
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the pr/Itay-Tsabary-Starkware/tsabary/remote_connetion/7e0d8402 branch from c4d0def to faf3cfd Compare September 22, 2024 06:52
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the title refactor(mempool_infra): change remote server to send messages to loc… refactor(mempool_infra): change remote server to send messages to local server Sep 22, 2024
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the base branch from main to pr/Itay-Tsabary-Starkware/tsabary/remote_connetion/16fb3ec0 September 22, 2024 06:52
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the pr/Itay-Tsabary-Starkware/tsabary/remote_connetion/16fb3ec0 branch from 17814b1 to 4944dcf Compare September 22, 2024 07:05
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the pr/Itay-Tsabary-Starkware/tsabary/remote_connetion/7e0d8402 branch 4 times, most recently from 84ffbda to d0c2246 Compare September 22, 2024 08:40
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the pr/Itay-Tsabary-Starkware/tsabary/remote_connetion/16fb3ec0 branch from 5054e21 to ab73738 Compare September 22, 2024 08:40
Copy link
Contributor

@lev-starkware lev-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 7 files at r1, 4 of 4 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the pr/Itay-Tsabary-Starkware/tsabary/remote_connetion/16fb3ec0 branch from ab73738 to 0faafcc Compare September 22, 2024 10:29
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the pr/Itay-Tsabary-Starkware/tsabary/remote_connetion/7e0d8402 branch from d0c2246 to 98ecb4e Compare September 22, 2024 10:29
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the title refactor(mempool_infra): change remote server to send messages to local server refactor(mempool_infra): change remote server to send messages to loc… Sep 22, 2024
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the base branch from pr/Itay-Tsabary-Starkware/tsabary/remote_connetion/16fb3ec0 to main September 22, 2024 11:08
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware merged commit 169929f into main Sep 22, 2024
18 of 29 checks passed
Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [66.676 ms 66.791 ms 66.929 ms]
change: [-7.2943% -4.1909% -1.4146%] (p = 0.00 < 0.05)
Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
5 (5.00%) high severe

@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants