Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main-v0.13.2 into main #908

Closed

Conversation

meship-starkware
Copy link
Contributor

@meship-starkware meship-starkware commented Sep 22, 2024

This change is Reviewable

@meship-starkware
Copy link
Contributor Author

Src Dst .github/workflows/main.yml
Src Dst commitlint.config.js

Copy link
Contributor Author

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 16 files at r1, 8 of 8 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @meship-starkware)

Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [66.631 ms 66.716 ms 66.807 ms]
change: [-12.607% -7.8243% -3.5901%] (p = 0.00 < 0.05)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
3 (3.00%) high mild
1 (1.00%) high severe

full_committer_flow performance regressed!
full_committer_flow time: [49.959 ms 57.040 ms 66.544 ms]
change: [+2.9680% +17.896% +34.387%] (p = 0.02 < 0.05)
Performance has regressed.
Found 12 outliers among 100 measurements (12.00%)
5 (5.00%) high mild
7 (7.00%) high severe

Copy link

Benchmark movements:
full_committer_flow performance regressed!
full_committer_flow time: [49.919 ms 56.559 ms 65.109 ms]
change: [+3.8453% +17.826% +36.269%] (p = 0.01 < 0.05)
Performance has regressed.
Found 12 outliers among 100 measurements (12.00%)
1 (1.00%) high mild
11 (11.00%) high severe

@meship-starkware meship-starkware force-pushed the meshi/merge-main-v0.13.2-into-main-1726991910 branch from a9b5ec9 to e623474 Compare September 22, 2024 08:21
Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [66.215 ms 66.352 ms 66.537 ms]
change: [-9.1283% -5.5744% -2.4221%] (p = 0.00 < 0.05)
Performance has improved.
Found 12 outliers among 100 measurements (12.00%)
6 (6.00%) high mild
6 (6.00%) high severe

@meship-starkware meship-starkware force-pushed the meshi/merge-main-v0.13.2-into-main-1726991910 branch from e623474 to 53f10b4 Compare September 22, 2024 08:27
Copy link

Benchmark movements:
full_committer_flow performance regressed!
full_committer_flow time: [49.792 ms 57.576 ms 68.148 ms]
change: [+2.2344% +19.532% +40.586%] (p = 0.02 < 0.05)
Performance has regressed.
Found 15 outliers among 100 measurements (15.00%)
15 (15.00%) high severe

@meship-starkware meship-starkware deleted the meshi/merge-main-v0.13.2-into-main-1726991910 branch September 22, 2024 08:37
Copy link

codecov bot commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.20%. Comparing base (1ad069a) to head (53f10b4).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #908      +/-   ##
==========================================
- Coverage   74.29%   74.20%   -0.09%     
==========================================
  Files         358      359       +1     
  Lines       36280    36255      -25     
  Branches    36280    36255      -25     
==========================================
- Hits        26953    26902      -51     
- Misses       7188     7216      +28     
+ Partials     2139     2137       -2     
Flag Coverage Δ
74.20% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants