Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename chunk_id->message_id #909

Merged
merged 2 commits into from
Sep 22, 2024
Merged

Conversation

guy-starkware
Copy link
Contributor

@guy-starkware guy-starkware commented Sep 22, 2024

This change is Reviewable

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.28%. Comparing base (6da0e49) to head (cf3f846).
Report is 89 commits behind head on main.

Files with missing lines Patch % Lines
...rates/papyrus_protobuf/src/converters/consensus.rs 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #909      +/-   ##
==========================================
- Coverage   76.01%   74.28%   -1.74%     
==========================================
  Files         359      357       -2     
  Lines       38301    36214    -2087     
  Branches    38301    36214    -2087     
==========================================
- Hits        29116    26902    -2214     
- Misses       6850     7175     +325     
+ Partials     2335     2137     -198     
Flag Coverage Δ
74.28% <50.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dan-starkware dan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)

@guy-starkware guy-starkware merged commit f68bd90 into main Sep 22, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants