build: blockifier regression test add block info

[AvivYossef-starkware]

This change is 

[AvivYossef-starkware]

• test: blockifier regression test test utils #956 : 2 dependent PRs (#943 , #980 )
• build: add more utils to regression test #952
• build: blockifier regression test add get fee token addresses #948
• build: blockifier regression test add block info #946 👈
• build: regression test crate #945
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @AvivYossef-starkware and the rest of your teammates on Graphite

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.29%. Comparing base (b0cfe82) to head (1a596c3).
Report is 107 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (b0cfe82) and HEAD (1a596c3). Click for more details.

HEAD has 2 uploads less than BASE

Flag	BASE (b0cfe82)	HEAD (1a596c3)
	3	1

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #946      +/-   ##
==========================================
- Coverage   74.18%   68.29%   -5.90%     
==========================================
  Files         359      131     -228     
  Lines       36240    13075   -23165     
  Branches    36240    13075   -23165     
==========================================
- Hits        26886     8930   -17956     
+ Misses       7220     3681    -3539     
+ Partials     2134      464    -1670     

Flag	Coverage Δ
	68.29% <ø> (-5.90%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[aner-starkware]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware)

---

crates/gateway/src/lib.rs line 11 at r2 (raw file):

#[cfg(test)]
mod rpc_state_reader_test;
pub mod state_reader;

Blocking until approved by @dorimedini-starkware

Code quote:

pub mod state_reader;

[dorimedini-starkware]

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @aner-starkware and @dorimedini-starkware)

---

crates/gateway/src/lib.rs line 11 at r2 (raw file):

Previously, aner-starkware wrote…

Blocking until approved by @dorimedini-starkware

this should be approved by someone from GW team

[dorimedini-starkware]

Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @aner-starkware and @AvivYossef-starkware)

---

crates/blockifier_regression_test/src/test_state_reader.rs line 47 at r2 (raw file):

    pub fn get_block_info(&self) -> StateResult<BlockInfo> {
        self.0.get_block_info()
    }

consider adding #[derive(derive_more::Deref)] to TestStateReader - and you may be able to delete this getter. non-blocking

Code quote:

    pub fn get_block_info(&self) -> StateResult<BlockInfo> {
        self.0.get_block_info()
    }

[Yael-Starkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @AvivYossef-starkware and @dafnamatsry)

---

crates/gateway/src/lib.rs line 11 at r2 (raw file):

Previously, dorimedini-starkware wrote…

this should be approved by someone from GW team

this is required for the get_block_info functionality?
I think it's fine to make it public but maybe we should rearrange these files as a shared util.
@dafnamatsry wdyt?

[AvivYossef-starkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dafnamatsry and @dorimedini-starkware)

---

crates/blockifier_regression_test/src/test_state_reader.rs line 47 at r2 (raw file):

Previously, dorimedini-starkware wrote…

consider adding #[derive(derive_more::Deref)] to TestStateReader - and you may be able to delete this getter. non-blocking

I believe that it might be misleading since I inherited some of the inner methods and changed some of them.

---

crates/gateway/src/lib.rs line 11 at r2 (raw file):

Previously, Yael-Starkware (YaelD) wrote…

this is required for the get_block_info functionality?
I think it's fine to make it public but maybe we should rearrange these files as a shared util.
@dafnamatsry wdyt?

Yes, I need to use the MempoolStateReader trait to get this functionality

[aner-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)

[dorimedini-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)