-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: blockifier regression test add get fee token addresses #948
build: blockifier regression test add get fee token addresses #948
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @AvivYossef-starkware and the rest of your teammates on Graphite |
6ca2811
to
d3ba818
Compare
4e49777
to
5545b16
Compare
Benchmark movements: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #948 +/- ##
===========================================
- Coverage 74.18% 63.35% -10.83%
===========================================
Files 359 125 -234
Lines 36240 15772 -20468
Branches 36240 15772 -20468
===========================================
- Hits 26886 9993 -16893
+ Misses 7220 4997 -2223
+ Partials 2134 782 -1352
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
d3ba818
to
5b3d719
Compare
5545b16
to
a0fce57
Compare
a0fce57
to
d56d948
Compare
Benchmark movements: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: 4 of 5 files reviewed, 2 unresolved discussions (waiting on @AvivYossef-starkware)
crates/papyrus_execution/src/lib.rs
line 94 at r3 (raw file):
const STARKNET_VERSION_O_13_1: &str = "0.13.1"; const STARKNET_VERSION_O_13_2: &str = "0.13.2"; pub const STRK_FEE_CONTRACT_ADDRESS: &str =
Blocked until approved by @dorimedini-starkware.
Code quote:
pub
crates/papyrus_execution/src/lib.rs
line 96 at r3 (raw file):
pub const STRK_FEE_CONTRACT_ADDRESS: &str = "0x04718f5a0fc34cc1af16a1cdee98ffb20c31f5cd61d6ab07201858f4287c938d"; pub const ETH_FEE_CONTRACT_ADDRESS: &str =
Blocked until approved by @dorimedini-starkware.
Code quote:
pub
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 4 of 5 files reviewed, 2 unresolved discussions (waiting on @aner-starkware and @dorimedini-starkware)
crates/papyrus_execution/src/lib.rs
line 94 at r3 (raw file):
Previously, aner-starkware wrote…
Blocked until approved by @dorimedini-starkware.
fine by me. maybe the const location isn't ideal but that's out of scope
crates/papyrus_execution/src/lib.rs
line 96 at r3 (raw file):
Previously, aner-starkware wrote…
Blocked until approved by @dorimedini-starkware.
fine by me
5b3d719
to
435efac
Compare
d56d948
to
975a268
Compare
Benchmark movements: |
435efac
to
cb8097e
Compare
975a268
to
c8f5f0f
Compare
0e97462
to
1a596c3
Compare
c8f5f0f
to
c61a186
Compare
Benchmark movements: |
c61a186
to
6e9abde
Compare
6e9abde
to
7db5d72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 5 files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
7db5d72
to
446df05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r4, 1 of 2 files at r5, 1 of 1 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)
This change is