Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: blockifier regression test add get fee token addresses #948

Merged

Conversation

AvivYossef-starkware
Copy link
Contributor

@AvivYossef-starkware AvivYossef-starkware commented Sep 23, 2024

This change is Reviewable

Copy link
Contributor Author

AvivYossef-starkware commented Sep 23, 2024

Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [66.260 ms 66.334 ms 66.421 ms]
change: [-8.5810% -5.1834% -2.1504%] (p = 0.00 < 0.05)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
4 (4.00%) high severe

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.35%. Comparing base (b0cfe82) to head (446df05).
Report is 123 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (b0cfe82) and HEAD (446df05). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (b0cfe82) HEAD (446df05)
3 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #948       +/-   ##
===========================================
- Coverage   74.18%   63.35%   -10.83%     
===========================================
  Files         359      125      -234     
  Lines       36240    15772    -20468     
  Branches    36240    15772    -20468     
===========================================
- Hits        26886     9993    -16893     
+ Misses       7220     4997     -2223     
+ Partials     2134      782     -1352     
Flag Coverage Δ
63.35% <ø> (-10.83%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [67.015 ms 67.080 ms 67.156 ms]
change: [-8.2939% -4.9883% -2.1362%] (p = 0.00 < 0.05)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
2 (2.00%) high mild
2 (2.00%) high severe

Copy link
Contributor

@aner-starkware aner-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: 4 of 5 files reviewed, 2 unresolved discussions (waiting on @AvivYossef-starkware)


crates/papyrus_execution/src/lib.rs line 94 at r3 (raw file):

const STARKNET_VERSION_O_13_1: &str = "0.13.1";
const STARKNET_VERSION_O_13_2: &str = "0.13.2";
pub const STRK_FEE_CONTRACT_ADDRESS: &str =

Blocked until approved by @dorimedini-starkware.

Code quote:

pub

crates/papyrus_execution/src/lib.rs line 96 at r3 (raw file):

pub const STRK_FEE_CONTRACT_ADDRESS: &str =
    "0x04718f5a0fc34cc1af16a1cdee98ffb20c31f5cd61d6ab07201858f4287c938d";
pub const ETH_FEE_CONTRACT_ADDRESS: &str =

Blocked until approved by @dorimedini-starkware.

Code quote:

pub

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 4 of 5 files reviewed, 2 unresolved discussions (waiting on @aner-starkware and @dorimedini-starkware)


crates/papyrus_execution/src/lib.rs line 94 at r3 (raw file):

Previously, aner-starkware wrote…

Blocked until approved by @dorimedini-starkware.

fine by me. maybe the const location isn't ideal but that's out of scope


crates/papyrus_execution/src/lib.rs line 96 at r3 (raw file):

Previously, aner-starkware wrote…

Blocked until approved by @dorimedini-starkware.

fine by me

Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [66.363 ms 66.472 ms 66.619 ms]
change: [-8.6581% -5.3092% -2.4134%] (p = 0.00 < 0.05)
Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
3 (3.00%) high mild
3 (3.00%) high severe

Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.452 ms 34.498 ms 34.552 ms]
change: [-5.7759% -4.4440% -3.1992%] (p = 0.00 < 0.05)
Performance has improved.
Found 10 outliers among 100 measurements (10.00%)
3 (3.00%) high mild
7 (7.00%) high severe

@AvivYossef-starkware AvivYossef-starkware changed the base branch from aviv/regression_test_add_get_blok_info to graphite-base/948 September 26, 2024 13:45
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/regression_test_add_get_fee_token_addresses branch from c61a186 to 6e9abde Compare September 26, 2024 13:45
@AvivYossef-starkware AvivYossef-starkware changed the base branch from graphite-base/948 to main September 26, 2024 13:45
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/regression_test_add_get_fee_token_addresses branch from 6e9abde to 7db5d72 Compare September 26, 2024 13:45
Copy link
Contributor

@aner-starkware aner-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 5 files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/regression_test_add_get_fee_token_addresses branch from 7db5d72 to 446df05 Compare September 29, 2024 09:03
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r4, 1 of 2 files at r5, 1 of 1 files at r6, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

@AvivYossef-starkware AvivYossef-starkware merged commit b77b36a into main Sep 29, 2024
24 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants