Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: blockifier regression test compile class #980

Open
wants to merge 1 commit into
base: aviv/test_regression_test_utils
Choose a base branch
from

Conversation

AvivYossef-starkware
Copy link
Contributor

@AvivYossef-starkware AvivYossef-starkware commented Sep 24, 2024

This change is Reviewable

Copy link
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @AvivYossef-starkware and the rest of your teammates on Graphite Graphite

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 60 lines in your changes missing coverage. Please review.

Project coverage is 61.09%. Comparing base (b65faeb) to head (5120916).

Files with missing lines Patch % Lines
crates/blockifier_regression_test/src/compile.rs 0.00% 60 Missing ⚠️
Additional details and impacted files
@@                         Coverage Diff                         @@
##           aviv/test_regression_test_utils     #980      +/-   ##
===================================================================
- Coverage                            61.34%   61.09%   -0.25%     
===================================================================
  Files                                  127      128       +1     
  Lines                                12988    13048      +60     
  Branches                             12988    13048      +60     
===================================================================
+ Hits                                  7967     7972       +5     
- Misses                                4622     4677      +55     
  Partials                               399      399              
Flag Coverage Δ
61.09% <0.00%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/blockifier_regression_test_comile_class branch from f0541a6 to 5120916 Compare September 24, 2024 11:23
Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [66.463 ms 66.559 ms 66.667 ms]
change: [-9.2720% -5.7826% -2.6754%] (p = 0.00 < 0.05)
Performance has improved.
Found 10 outliers among 100 measurements (10.00%)
7 (7.00%) high mild
3 (3.00%) high severe

@AvivYossef-starkware AvivYossef-starkware marked this pull request as ready for review September 24, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant