Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge main-v0.13.2 into main #981

Merged
merged 6 commits into from
Sep 24, 2024
Merged

Merge main-v0.13.2 into main #981

merged 6 commits into from
Sep 24, 2024

Conversation

noaov1
Copy link
Collaborator

@noaov1 noaov1 commented Sep 24, 2024 •
edited
Loading

This change is Reviewable

@noaov1 noaov1 requested review from alon-dotan-starkware and removed request for alon-dotan-starkware September 24, 2024 11:11
@github-actions GitHub Actions
Copy link

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [34.863 ms 35.187 ms 35.550 ms]
change: [+1.4860% +2.5093% +3.5008%] (p = 0.00 < 0.05)
Performance has regressed.
Found 15 outliers among 100 measurements (15.00%)
2 (2.00%) high mild
13 (13.00%) high severe

alon-dotan-starkware
alon-dotan-starkware approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@alon-dotan-starkware alon-dotan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, 4 of 4 files at r3, 10 of 10 files at r4, 4 of 4 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

dorimedini-starkware
dorimedini-starkware approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noaov1)

@noaov1 noaov1 merged commit e395a89 into main Sep 24, 2024
23 of 42 checks passed
@noaov1 noaov1 deleted the noa/merge-main-v0.13.2-into-main-1727176225 branch September 24, 2024 11:39
@yoavGrs yoavGrs mentioned this pull request Sep 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alon-dotan-starkware alon-dotan-starkware alon-dotan-starkware approved these changes

@dorimedini-starkware dorimedini-starkware dorimedini-starkware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@noaov1 @alon-dotan-starkware @dorimedini-starkware @nadin-Starkware