refactor(blockifier): split pre validate test by charge fee

[yoavGrs]

This change is 

[yoavGrs]

• refactor(blockifier): remove constant from pre validate test #996
• refactor(blockifier): check gas and fee in pre validate test #995
• refactor(blockifier): split pre validate test by charge fee #994 👈
• feat(starknet_api): chain gas prices hash (#962) #993
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @yoavGrs and the rest of your teammates on Graphite

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.05%. Comparing base (b0cfe82) to head (8cb19f7).
Report is 82 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #994      +/-   ##
==========================================
- Coverage   74.18%   70.05%   -4.13%     
==========================================
  Files         359       87     -272     
  Lines       36240    11219   -25021     
  Branches    36240    11219   -25021     
==========================================
- Hits        26886     7860   -19026     
+ Misses       7220     2971    -4249     
+ Partials     2134      388    -1746     

Flag	Coverage Δ
	70.05% <ø> (-4.13%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dorimedini-starkware]

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @yoavGrs)

a discussion (no related file):
why split? lots of code duplication now, no?

---

[yoavGrs]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)

a discussion (no related file):

Previously, dorimedini-starkware wrote…

why split? lots of code duplication now, no?

In the last PR, there is some code duplication in the second scenario. I can move this duplication to a shared source, but it's not too bad IMO to leave it like that.
I don't like long tests, in which the state at the beginning is not necessary for the validations at the end.
It's also possible to split it another way (test for each case?).

---

[dorimedini-starkware]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yoavGrs)

---

crates/blockifier/src/transaction/execution_flavors_test.rs line 385 at r1 (raw file):

    // Second scenario: resource bounds greater than balance.

    // TODO(Ori, 1/2/2024): Write an indicative expect message explaining why the conversion works.

you can delete this

Code quote:

// TODO(Ori, 1/2/2024): Write an indicative expect message explaining why the conversion works.

[dorimedini-starkware]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yoavGrs)

[yoavGrs]

Merge activity

• Sep 25, 11:35 PM EDT: @yoavGrs started a stack merge that includes this pull request via Graphite.
• Sep 25, 11:36 PM EDT: @yoavGrs merged this pull request with Graphite.